Skip to content

Add test to make sure appends create conversation field#3650

Merged
lferran merged 1 commit into
mainfrom
add-test-for-create-on-append-2
May 14, 2026
Merged

Add test to make sure appends create conversation field#3650
lferran merged 1 commit into
mainfrom
add-test-for-create-on-append-2

Conversation

@lferran
Copy link
Copy Markdown
Contributor

@lferran lferran commented May 14, 2026

Description

[sc-14709]

How was this PR tested?

Describe how you tested this PR.

@lferran lferran changed the title Add test to make sure appends create field Add test to make sure appends create conversation field May 14, 2026
@lferran lferran requested a review from a team May 14, 2026 09:34
@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.21%. Comparing base (ee0ca16) to head (a2912d6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3650      +/-   ##
==========================================
+ Coverage   85.18%   85.21%   +0.02%     
==========================================
  Files         563      563              
  Lines       48465    48465              
  Branches    14173    14173              
==========================================
+ Hits        41287    41300      +13     
+ Misses       6560     6548      -12     
+ Partials      618      617       -1     
Flag Coverage Δ
nidx 79.75% <ø> (+<0.01%) ⬆️
nucliadb 73.55% <100.00%> (+0.01%) ⬆️
nucliadb-ingest 43.60% <0.00%> (ø)
nucliadb-reader 43.64% <50.00%> (+0.03%) ⬆️
nucliadb-search 54.69% <0.00%> (ø)
nucliadb-standalone 46.01% <0.00%> (ø)
nucliadb-train 44.67% <0.00%> (ø)
nucliadb-writer 46.94% <0.00%> (+<0.01%) ⬆️
nucliadb_dataset 73.65% <ø> (ø)
nucliadb_models 71.55% <ø> (ø)
nucliadb_sdk 83.08% <ø> (ø)
nucliadb_telemetry 72.33% <ø> (ø)
nucliadb_utils 80.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lferran lferran merged commit af8bde9 into main May 14, 2026
41 checks passed
@lferran lferran deleted the add-test-for-create-on-append-2 branch May 14, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants