Chart shared: Fix default key for S3 certificate validation#3654
Merged
zepellin merged 2 commits intoMay 15, 2026
Merged
Conversation
lferran
approved these changes
May 15, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3654 +/- ##
==========================================
- Coverage 85.18% 85.15% -0.03%
==========================================
Files 563 563
Lines 48458 48462 +4
Branches 14169 14169
==========================================
- Hits 41279 41270 -9
- Misses 6560 6574 +14
+ Partials 619 618 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor configuration update to the S3 storage settings in the
charts/nucliadb_shared/values.yamlfile. The change renames thes3_verify_sslparameter tos3_verify_ssl_certificatefor improved clarity and accuracy.