Skip to content

Chart shared: Fix default key for S3 certificate validation#3654

Merged
zepellin merged 2 commits into
mainfrom
Chart-shared-Fix-default-key-for-S3-certificate-validation
May 15, 2026
Merged

Chart shared: Fix default key for S3 certificate validation#3654
zepellin merged 2 commits into
mainfrom
Chart-shared-Fix-default-key-for-S3-certificate-validation

Conversation

@zepellin
Copy link
Copy Markdown
Contributor

This pull request makes a minor configuration update to the S3 storage settings in the charts/nucliadb_shared/values.yaml file. The change renames the s3_verify_ssl parameter to s3_verify_ssl_certificate for improved clarity and accuracy.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.15%. Comparing base (b334bf8) to head (065a76c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3654      +/-   ##
==========================================
- Coverage   85.18%   85.15%   -0.03%     
==========================================
  Files         563      563              
  Lines       48458    48462       +4     
  Branches    14169    14169              
==========================================
- Hits        41279    41270       -9     
- Misses       6560     6574      +14     
+ Partials      619      618       -1     
Flag Coverage Δ
nidx 79.75% <ø> (+0.02%) ⬆️
nucliadb 73.42% <ø> (-0.12%) ⬇️
nucliadb-ingest 43.58% <ø> (-0.01%) ⬇️
nucliadb-reader 43.64% <ø> (-0.01%) ⬇️
nucliadb-search 54.69% <ø> (+<0.01%) ⬆️
nucliadb-standalone 46.01% <ø> (-0.01%) ⬇️
nucliadb-train 44.66% <ø> (-0.01%) ⬇️
nucliadb-writer 46.93% <ø> (+<0.01%) ⬆️
nucliadb_dataset 73.65% <ø> (ø)
nucliadb_models 71.55% <ø> (ø)
nucliadb_sdk 83.08% <ø> (ø)
nucliadb_telemetry 72.33% <ø> (ø)
nucliadb_utils 80.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zepellin zepellin merged commit 140fefc into main May 15, 2026
41 checks passed
@zepellin zepellin deleted the Chart-shared-Fix-default-key-for-S3-certificate-validation branch May 15, 2026 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants