Skip to content

feat: added raw output type for jfr and pprof#26

Merged
mangglesh merged 3 commits into
masterfrom
raw_addition
Jul 7, 2025
Merged

feat: added raw output type for jfr and pprof#26
mangglesh merged 3 commits into
masterfrom
raw_addition

Conversation

@mangglesh

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @mangglesh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new 'raw' output type for the JFR (Java Flight Recorder) and Go Pprof profiling tools. This enhancement allows users to retrieve the unprocessed, raw profiling data directly, providing more flexibility for custom analysis or integration with other tools beyond the standard visualizations.

Highlights

  • New Output Type Support: I've added 'Raw' as a supported output type for both the Jcmd (Java Flight Recorder) and PProf (Go Profiler) tools in the API definitions, allowing users to request unprocessed profiling data.
  • JFR Raw Output Implementation: For JFR, I've implemented the logic to generate raw output by executing the jfr summary command on the collected .jfr files, providing a textual summary of the recording.
  • Go Pprof Raw Output Implementation: For Go Pprof, I've enhanced the profiler to fetch both CPU and Heap profiles, convert them to a raw text format using go tool pprof --raw, and then combine them into a single raw output file.
  • File Extension Handling: I've updated the file extension logic to correctly assign the .jfr extension to raw JFR outputs and refined the handling for various other Jcmd output types.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for a raw output type for both jfr and pprof profilers. The implementation for go_pprof has a critical regression where the nsenter command was removed, which will break profiling. I've also pointed out several medium-severity issues, including resource leaks. Please review the feedback, especially the critical items, to ensure the functionality works as expected.

Comment thread internal/agent/profiler/go_pprof.go
Comment thread internal/agent/profiler/go_pprof.go
Comment thread internal/agent/profiler/common/common.go
Comment thread internal/agent/profiler/go_pprof.go Outdated
Comment thread internal/agent/profiler/go_pprof.go Outdated
Comment thread internal/agent/profiler/jvm/jcmd.go Outdated
Comment thread internal/agent/profiler/jvm/jcmd.go
@mangglesh mangglesh merged commit d1f7493 into master Jul 7, 2025
2 checks passed
@mayankpande88 mayankpande88 deleted the raw_addition branch May 12, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants