Skip to content

Remove isomorphic fetch and isomorphic form data#132

Merged
mmktomato merged 4 commits into
nulab:masterfrom
katayama8000:remove-isomorphic-fetch-and-isomorphic-form-data
May 8, 2026
Merged

Remove isomorphic fetch and isomorphic form data#132
mmktomato merged 4 commits into
nulab:masterfrom
katayama8000:remove-isomorphic-fetch-and-isomorphic-form-data

Conversation

@katayama8000
Copy link
Copy Markdown
Contributor

isomorphic-fetch and isomorphic-form-data were development dependencies used only in tests. With Node.js 18.x (our test environment) natively supporting fetch and FormData APIs, these polyfills are no longer needed.

@mmktomato
Copy link
Copy Markdown
Member

@katayama8000
Thank you for your pull request!
fetch in the global scope is no longer an experimental feature as of Node.js v21.
Since v20 is still in active use, I will do a further check and merge this PR once v20 reaches its EOL at the end of April.

See #87

@mmktomato
Copy link
Copy Markdown
Member

@katayama8000
Now this PR can be merged as Node.js v20 officially retired. Can you check the conflicts?

@katayama8000
Copy link
Copy Markdown
Contributor Author

@copilot fix the conflicts

@mmktomato
Copy link
Copy Markdown
Member

@katayama8000
LGTM!!! Thank you!!!!

@mmktomato mmktomato merged commit 47d7321 into nulab:master May 8, 2026
5 checks passed
@katayama8000 katayama8000 deleted the remove-isomorphic-fetch-and-isomorphic-form-data branch May 8, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants