Revert "add xfail mark to test_qt_image_qapplication.py::test_sanity"#21
Closed
radarhere wants to merge 1 commit into
Closed
Revert "add xfail mark to test_qt_image_qapplication.py::test_sanity"#21radarhere wants to merge 1 commit into
test_qt_image_qapplication.py::test_sanity"#21radarhere wants to merge 1 commit into
Conversation
Author
|
I don't know why lint is failing. it passes in my repository - https://github.com/radarhere/Pillow/actions/runs/4035776334 |
|
See https://stackoverflow.com/a/75269701/724176 / PyCQA/isort#2078
|
Author
|
Thanks for the solution. I've created python-pillow#6920, since we'll want to avoid such failures in other builds as well. |
This reverts commit 380a697.
Owner
|
Thank you, I've pushed an identical commit independently of this PR. |
nulano
pushed a commit
that referenced
this pull request
Dec 12, 2023
Fix documentation link to PIL.ImageFont.Layout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggestion for python-pillow#6888
Given that python-pillow#6915 has been merged into main, I'm hoping that test_qt_image_qapplication.py::test_sanity will pass more consistently now.