fix: resolve SonarCloud Medium severity issues (97 issues) (#154)

- Use node: prefix for built-in modules (fs, path, os, crypto, child_process)
- Replace parseInt() with Number.parseInt() for consistency
- Add explicit regex grouping with non-capturing groups
- Remove nested template literals in documentation.internal.ts
- Use optional chaining in flagValidator.ts
- Add readonly modifier to FileLogWriter.config
Files: 7 source files, 8 test files (15 total)

🖥️ IDE: [Cursor](https://cursor.sh)
🔌 Extension: [Claude Code](https://claude.ai/download)


Model-Raw: claude-opus-4-5-20251101

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>

Author: nullvariant

extensions/git-id-switcher/src/documentation.internal.ts

@@ -236,8 +236,10 @@ export function renderMarkdown(raw: string): string {
       const rows = bodyRows.trim().split(/\r?\n/);
       const bodyHtml = rows.map((row: string) => {
         // Remove leading/trailing | then split, keeping empty cells
-        const cells = row.replace(/^\||\|$/g, '').split('|').map((c: string) => c.trim());
-        return `<tr>${cells.map((c: string) => `<td>${c}</td>`).join('')}</tr>`;
+        // Regex uses non-capturing groups for explicit precedence: (^|) OR (|$)
+        const cells = row.replace(/(?:^\|)|(?:\|$)/g, '').split('|').map((c: string) => c.trim());
+        const cellsHtml = cells.map((c: string) => '<td>' + c + '</td>').join('');
+        return '<tr>' + cellsHtml + '</tr>';
       }).join('');
       return `<table><thead><tr>${headerHtml}</tr></thead><tbody>${bodyHtml}</tbody></table>`;
     }
@@ -279,12 +281,12 @@ export function renderMarkdown(raw: string): string {
 
   // Step 13: Restore inline code
   html = html.replace(/%%INLINECODE_(\d+)%%/g, (_match, index: string) => {
-    return inlineCodes[parseInt(index, 10)];
+    return inlineCodes[Number.parseInt(index, 10)];
   });
 
   // Step 14: Restore code blocks
   html = html.replace(/%%CODEBLOCK_(\d+)%%/g, (_match, index: string) => {
-    return codeBlocks[parseInt(index, 10)];
+    return codeBlocks[Number.parseInt(index, 10)];
   });
 
   // Step 15: Convert double newlines to paragraph breaks

extensions/git-id-switcher/src/documentation.ts

@@ -11,7 +11,7 @@
  */
 
 import * as vscode from 'vscode';
-import * as crypto from 'crypto';
+import * as crypto from 'node:crypto';
 
 // Import internal functions (testable without VS Code)
 import {
@@ -435,7 +435,7 @@ async function fetchDocumentByPath(path: string): Promise<string | null> {
     if (response.ok) {
       // DoS prevention: Check Content-Length header before reading body
       const contentLength = response.headers.get('content-length');
-      if (contentLength && parseInt(contentLength, 10) > MAX_CONTENT_SIZE) {
+      if (contentLength && Number.parseInt(contentLength, 10) > MAX_CONTENT_SIZE) {
         console.warn('[Git ID Switcher] Documentation too large, rejecting');
         return null;
       }

extensions/git-id-switcher/src/fileLogWriter.ts

@@ -5,8 +5,8 @@
  * Provides file-based log persistence for audit trails.
  */
 
-import * as fs from 'fs';
-import * as path from 'path';
+import * as fs from 'node:fs';
+import * as path from 'node:path';
 import type { StructuredLog, ILogWriter, FileLogConfig } from './logTypes';
 import { isSecurePath } from './pathSecurity';
 
@@ -19,7 +19,7 @@ import { isSecurePath } from './pathSecurity';
  * - Clean up old log files
  */
 export class FileLogWriter implements ILogWriter {
-  private config: FileLogConfig;
+  private readonly config: FileLogConfig;
   private currentFilePath: string = '';
   private writeStream: fs.WriteStream | null = null;
   private currentFileSize: number = 0;

extensions/git-id-switcher/src/flagValidator.ts

@@ -108,7 +108,7 @@ function checkCombinedFlagAllowlist(
 ): CombinedFlagResult {
   // Check if this command has allowed combined patterns
   const commandPatterns = ALLOWED_COMBINED_PATTERNS[command];
-  if (commandPatterns && commandPatterns.includes(flagChars)) {
+  if (commandPatterns?.includes(flagChars)) {
     return { valid: true };
   }
 

extensions/git-id-switcher/src/pathSanitizer.ts

@@ -7,7 +7,7 @@
  * Separated from SecurityLogger for Single Responsibility Principle.
  */
 
-import * as path from 'path';
+import * as path from 'node:path';
 import { PATH_MAX, MAX_PATTERN_CHECK_LENGTH } from './constants';
 import { CONTROL_CHAR_REGEX_ALL } from './validators/common';
 

extensions/git-id-switcher/src/pathUtils.ts

@@ -5,9 +5,9 @@
  * Designed to prevent path traversal and symlink-based attacks.
  */
 
-import * as os from 'os';
-import * as path from 'path';
-import * as fs from 'fs';
+import * as os from 'node:os';
+import * as path from 'node:path';
+import * as fs from 'node:fs';
 import { isSecurePath, SecurePathResult } from './pathSecurity';
 import { PATH_MAX } from './constants';
 import { CONTROL_CHAR_REGEX_ALL, hasNullByte, hasPathTraversal } from './validators/common';

extensions/git-id-switcher/src/sshAgent.ts

@@ -8,8 +8,8 @@
  * @see https://owasp.org/www-community/attacks/Command_Injection
  */
 
-import * as fs from 'fs/promises';
-import * as path from 'path';
+import * as fs from 'node:fs/promises';
+import * as path from 'node:path';
 import * as vscode from 'vscode';
 import { Identity, getIdentitiesWithValidation } from './identity';
 import { sshAgentExec, sshKeygenExec } from './secureExec';

extensions/git-id-switcher/src/test/e2e/gitConfig.test.ts

@@ -25,10 +25,10 @@
 
 import * as assert from 'assert';
 import * as vscode from 'vscode';
-import * as path from 'path';
-import * as fs from 'fs';
-import * as os from 'os';
-import { execFileSync } from 'child_process';
+import * as path from 'node:path';
+import * as fs from 'node:fs';
+import * as os from 'node:os';
+import { execFileSync } from 'node:child_process';
 
 const EXTENSION_ID = 'nullvariant.git-id-switcher';
 
@@ -358,7 +358,7 @@ describe('Git Config E2E Test Suite', function () {
   describe('Repository State', () => {
     it('should report repository has at least one commit', () => {
       const commitCount = gitSync(['rev-list', '--count', 'HEAD'], tempRepoPath);
-      const count = parseInt(commitCount, 10);
+      const count = Number.parseInt(commitCount, 10);
       assert.ok(!isNaN(count) && count >= 1, `Repository should have at least one commit, got: ${commitCount}`);
     });
 

extensions/git-id-switcher/src/test/fileLogWriter.test.ts

@@ -64,9 +64,9 @@
  */
 
 import * as assert from 'assert';
-import * as fs from 'fs';
-import * as path from 'path';
-import * as os from 'os';
+import * as fs from 'node:fs';
+import * as path from 'node:path';
+import * as os from 'node:os';
 import { FileLogWriter } from '../fileLogWriter';
 import { LogLevel, FileLogConfig, StructuredLog } from '../logTypes';
 

extensions/git-id-switcher/src/test/i18n.test.ts

@@ -20,8 +20,8 @@
  */
 
 import * as assert from 'assert';
-import * as fs from 'fs';
-import * as path from 'path';
+import * as fs from 'node:fs';
+import * as path from 'node:path';
 
 // ============================================================================
 // Constants