docs(architecture): update for new src/ directory structure + fix ReDoS (#223)

* docs(architecture): update for new src/ directory structure
Update ARCHITECTURE.md to reflect the refactored directory structure:
- Update all file path references to new locations
- Replace logical grouping with actual directory structure
- Expand security layer documentation with all 13 files
- Update Command Execution Flow diagram
- Fix table alignments for consistency

🖥️ IDE: [Cursor](https://cursor.sh)
🔌 Extension: [Claude Code](https://claude.ai/download)

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Model-Raw: claude-opus-4-5-20251101

* fix(security): replace EMAIL_REGEX with split-based validation
Replace regex-based email validation with split-based approach to
prevent potential ReDoS (Regular Expression Denial of Service):
- Deprecate EMAIL_REGEX constant (kept for backward compatibility)
- Implement isValidEmail() using string operations instead of regex
- Add length limit (254 chars per RFC 5321)
- Add ReDoS resistance tests
SonarQube: typescript:S5852

🖥️ IDE: [Cursor](https://cursor.sh)
🔌 Extension: [Claude Code](https://claude.ai/download)

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Model-Raw: claude-opus-4-5-20251101

* chore: update version to 0.14.3 and fix table styles
- Bump version to 0.14.3
- Add changelog entry for ReDoS fix and ARCHITECTURE.md update
- Fix markdown table alignment per prettier-markdown

🖥️ IDE: [Cursor](https://cursor.sh)
🔌 Extension: [Claude Code](https://claude.ai/download)

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Model-Raw: claude-opus-4-5-20251101

---------

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>

Author: nullvariant

extensions/git-id-switcher/CHANGELOG.md

@@ -7,6 +7,23 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.14.3] - 2026-01-25
+
+### Security
+
+- **ReDoS Vulnerability Fix**: Replaced regex-based email validation with split-based approach
+  - `EMAIL_REGEX` marked as deprecated (kept for backward compatibility)
+  - New `isValidEmail()` function uses string operations instead of regex
+  - Added length limit (254 chars per RFC 5321)
+  - SonarQube: typescript:S5852
+
+### Changed
+
+- **ARCHITECTURE.md Updated**: Synchronized documentation with new directory structure
+  - Updated 30+ file path references to reflect Phase 1-5 refactoring
+  - Replaced logical grouping diagram with actual directory structure
+  - Expanded security layer documentation with all 13 files
+
 ## [0.14.2] - 2026-01-23
 
 ### Fixed

extensions/git-id-switcher/docs/ARCHITECTURE.md

@@ -2,7 +2,7 @@
   "name": "git-id-switcher",
   "displayName": "%extension.displayName%",
   "description": "%extension.description%",
-  "version": "0.14.2",
+  "version": "0.14.3",
   "publisher": "nullvariant",
   "icon": "images/icon.png",
   "engines": {

extensions/git-id-switcher/package.json

@@ -9,7 +9,7 @@
  */
 
 import { Identity } from './identity';
-import { EMAIL_REGEX, hasPathTraversal } from '../validators/common';
+import { isValidEmail, hasPathTraversal } from '../validators/common';
 
 export interface ValidationResult {
   valid: boolean;
@@ -70,11 +70,12 @@ function validateEmail(email: string | undefined, errors: string[]): void {
     return;
   }
 
-  if (!EMAIL_REGEX.test(email)) {
+  if (!isValidEmail(email)) {
     errors.push('email: invalid email format');
   }
 
   // Additional length check (RFC 5321)
+  // Note: isValidEmail already checks for 254 chars, but identity config allows 320
   if (email.length > 320) {
     errors.push('email: exceeds maximum length (320 characters)');
   }

extensions/git-id-switcher/src/identity/inputValidator.ts

@@ -162,6 +162,19 @@ function testIsValidEmail(): void {
   assert.strictEqual(isValidEmail('user @example.com'), false, 'Email with space should fail');
   assert.strictEqual(isValidEmail('user<tag>@example.com'), false, 'Email with angle brackets should fail');
 
+  // Additional edge cases (ReDoS prevention)
+  assert.strictEqual(isValidEmail(''), false, 'Empty string should fail');
+  assert.strictEqual(isValidEmail('user@@example.com'), false, 'Multiple @ should fail');
+  assert.strictEqual(isValidEmail('user@example.com.'), false, 'Domain ending with dot should fail');
+  assert.strictEqual(isValidEmail('a'.repeat(255) + '@example.com'), false, 'Email exceeding 254 chars should fail');
+
+  // ReDoS resistance test - should complete quickly even with adversarial input
+  const start = Date.now();
+  const adversarialInput = 'a'.repeat(100) + '@' + 'b'.repeat(100) + '.' + 'c'.repeat(50);
+  isValidEmail(adversarialInput);
+  const elapsed = Date.now() - start;
+  assert.ok(elapsed < 100, `ReDoS test should complete in <100ms, took ${elapsed}ms`);
+
   console.log('✅ isValidEmail tests passed!');
 }
 

extensions/git-id-switcher/src/test/validatorsCommon.test.ts

@@ -25,8 +25,8 @@ export const DOCUMENT_HASHES: Record<string, string> = {
   'AGENTS.md': '54f16b767e57686b3eb46a2b4aa02b378554cc492c32c49ed96588f6d184b6b8',
   'CODE_OF_CONDUCT.md': 'a5eb286c902437bbe0f6d409894f20e51c172fa869fe2f151bfa388f9d911b54',
   'CONTRIBUTING.md': '4150f8810aec7b2e8eff9f3c69ee1bae1374843f50a812efa6778cba27a833cd',
-  'extensions/git-id-switcher/CHANGELOG.md': '864fa5cd55227ade6c688cfcfe373473c9c564d89d17332ad46ceadc396986a9',
-  'extensions/git-id-switcher/docs/ARCHITECTURE.md': '47797f0b92d987c3102968befc974661d3af28664e442538cc9ac6e3df9a18f4',
+  'extensions/git-id-switcher/CHANGELOG.md': 'be7dae0e7edf02b42bf886dae0c54ac19f26f69f65b58ea0c4344b72155e5f16',
+  'extensions/git-id-switcher/docs/ARCHITECTURE.md': 'a7f9efa1eefdc535d516aa46357cffc916c8cb982e6b8943152cd06818d7ec1c',
   'extensions/git-id-switcher/docs/CONTRIBUTING.md': '7d6ad2bc4d8c838790754cb9df848cb65f9fdce7e1a13e5c965b83a3d5b6378c',
   'extensions/git-id-switcher/docs/DESIGN_PHILOSOPHY.md': 'f9718b61ac161cb466dbc76845688e7acacf4e5fdc4b8b9553269dba4a094f6b',
   'extensions/git-id-switcher/docs/i18n/ain/README.md': '4d309165e22a943b2a1791914db02bc2762d5fb643f5350a2426558ac7b3ae19',

extensions/git-id-switcher/src/ui/documentationInternal.ts

@@ -47,8 +47,9 @@ export const CONTROL_CHAR_REGEX_ALL = /[\x00-\x1f\x7f]/;
 /**
  * Email validation regex (simplified RFC 5322)
  *
- * Allows most valid email addresses while rejecting obvious invalid ones.
- * Used in validation.ts and configSchema.ts.
+ * @deprecated Use isValidEmail() instead. This regex is kept for backward
+ * compatibility but should not be used directly due to potential ReDoS concerns.
+ * @see isValidEmail
  */
 export const EMAIL_REGEX = /^[^\s@<>]+@[^\s@<>]+\.[^\s@<>]+$/;
 
@@ -160,11 +161,48 @@ export function hasInvisibleUnicode(s: string): boolean {
 /**
  * Validate an email address format
  *
+ * Uses a split-based approach to avoid ReDoS vulnerabilities.
+ * Validates: non-empty local part, single @, domain with at least one dot.
+ *
  * @param email - The email string to validate
  * @returns true if email format is valid
  */
 export function isValidEmail(email: string): boolean {
-  return EMAIL_REGEX.test(email);
+  // Length limit (RFC 5321: 254 chars max for email address)
+  if (email.length > 254 || email.length === 0) {
+    return false;
+  }
+
+  // No whitespace allowed
+  if (/\s/.test(email)) {
+    return false;
+  }
+
+  // No angle brackets allowed
+  if (email.includes('<') || email.includes('>')) {
+    return false;
+  }
+
+  // Split by @ - must have exactly one @
+  const atIndex = email.indexOf('@');
+  if (atIndex === -1 || atIndex !== email.lastIndexOf('@')) {
+    return false;
+  }
+
+  const local = email.slice(0, atIndex);
+  const domain = email.slice(atIndex + 1);
+
+  // Local part and domain must be non-empty
+  if (local.length === 0 || domain.length === 0) {
+    return false;
+  }
+
+  // Domain must contain at least one dot and not end with dot
+  if (!domain.includes('.') || domain.endsWith('.')) {
+    return false;
+  }
+
+  return true;
 }
 
 /**