perf(identity): add validation cache and remove deprecated aliases (#402)

* perf(identity): add validation cache and remove deprecated aliases
Cache getIdentitiesWithValidation() results in a module-level variable
to avoid redundant VS Code config reads and schema validation on every
call (up to MAX_IDENTITIES=1000 per invocation). Cache is invalidated
on configuration change via onDidChangeConfiguration.
Also removes 6 deprecated aliases (isPathSafe, isSecurePath,
validateNoControlChars, validateNoInvisibleUnicode, isKeyLoaded,
getGitAuthorFlag) and fixes valuesEqual() to return false (safe-side)
for large objects instead of a length-based heuristic.

🖥️ IDE: [Cursor](https://cursor.sh)
🔌 Extension: [Claude Code](https://claude.ai/download)

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Model-Raw: claude-opus-4-6

* fix(test): invalidate identity cache in E2E test setup/teardown
The identity cache introduced in the previous commit persists across
test cases. E2E tests that set up mock VS Code configurations need to
also call invalidateIdentityCache() alongside _resetCache() to ensure
each test starts with a fresh cache.

🖥️ IDE: [Cursor](https://cursor.sh)
🔌 Extension: [Claude Code](https://claude.ai/download)

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Model-Raw: claude-opus-4-6

* fix(ci): fix printf treating checklist items as options
printf interprets '- [ ] ...' as an invalid option flag because it
starts with a hyphen. Use '%s
' format string to pass the checklist
text as an argument instead of a format string.

🖥️ IDE: [Cursor](https://cursor.sh)
🔌 Extension: [Claude Code](https://claude.ai/download)

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Model-Raw: claude-opus-4-6

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: nullvariant

.github/workflows/blaze-bot.yml

@@ -99,13 +99,13 @@ jobs:
                 printf '`%s` → `%s`\n\n' "$BASE_VER" "$HEAD_VER"
                 if [ "$BUMP_TYPE" = "MAJOR" ]; then
                   printf '🔥🔥🔥 MAJOR RELEASE?! LET'"'"'S GOOOO!!! But wait... did you:\n\n'
-                  printf '- [ ] Update the CHANGELOG?\n'
-                  printf '- [ ] Check for breaking changes?\n'
-                  printf '- [ ] Run the full test suite?\n\n'
+                  printf '%s\n' '- [ ] Update the CHANGELOG?'
+                  printf '%s\n' '- [ ] Check for breaking changes?'
+                  printf '%s\n\n' '- [ ] Run the full test suite?'
                 elif [ "$BUMP_TYPE" = "MINOR" ]; then
-                  printf '🔥 New features incoming! Make sure:\n\n'
-                  printf '- [ ] Tests pass for the new features?\n'
-                  printf '- [ ] Documentation updated?\n\n'
+                  printf '%s\n\n' '🔥 New features incoming! Make sure:'
+                  printf '%s\n' '- [ ] Tests pass for the new features?'
+                  printf '%s\n\n' '- [ ] Documentation updated?'
                 else
                   printf '✨ Quick patch! Nice and clean.\n\n'
                 fi

extensions/git-id-switcher/CHANGELOG.md

@@ -7,6 +7,28 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.18.0] - 2026-03-30
+
+### Changed
+
+- **Identity validation caching**: `getIdentitiesWithValidation()` now caches validated results in a module-level variable, avoiding redundant VS Code config reads and schema validation on every call. Cache is automatically invalidated on configuration change via `onDidChangeConfiguration`
+- **Config change detection**: `valuesEqual()` in `ConfigChangeDetector` now returns `false` (changed) for large objects exceeding `MAX_STRINGIFY_SIZE`, instead of the previous length-based heuristic that could miss same-length but different-content objects
+- **Renamed** `resetValidationNotificationFlag()` to `invalidateIdentityCache()` to reflect its expanded responsibility (cache invalidation + notification flag reset)
+
+### Removed
+
+- **Deprecated aliases removed** (BREAKING for consumers importing these symbols directly):
+  - `isPathSafe` — use `isShellSafePath` instead
+  - `isSecurePath` — use `validatePathSecurity` instead
+  - `validateNoControlChars` — use `controlCharValidator` instead
+  - `validateNoInvisibleUnicode` — use `invisibleUnicodeValidator` instead
+  - `isKeyLoaded` — use `checkKeyLoadedInAgent` instead
+  - `getGitAuthorFlag()` — use `formatGitAuthor()` with template literal instead
+
+### Refactored
+
+- **UI module split** (via #401): Split `identityManager.ts` (1181 lines) into 4 responsibility-based modules: `identityAddForm.ts`, `identityEditFlow.ts`, `identityFormUtils.ts`, `identityFormValidation.ts`
+
 ## [0.17.1] - 2026-03-18
 
 ### Fixed

extensions/git-id-switcher/package.json

@@ -2,7 +2,7 @@
   "name": "git-id-switcher",
   "displayName": "%extension.displayName%",
   "description": "%extension.description%",
-  "version": "0.17.1",
+  "version": "0.18.0",
   "publisher": "nullvariant",
   "icon": "images/icon.png",
   "engines": {

extensions/git-id-switcher/src/core/configChangeDetector.ts

@@ -139,12 +139,12 @@ export class ConfigChangeDetector {
         const aStr = JSON.stringify(a);
         const bStr = JSON.stringify(b);
 
-        // If strings are too large, use length-based comparison as fallback
+        // Large objects: report as changed to guarantee config change detection
         if (
           aStr.length > LIMITS.MAX_STRINGIFY_SIZE ||
           bStr.length > LIMITS.MAX_STRINGIFY_SIZE
         ) {
-          return aStr.length === bStr.length && typeof a === typeof b;
+          return false;
         }
 
         return aStr === bStr;

extensions/git-id-switcher/src/core/extension.ts

@@ -5,7 +5,7 @@
  */
 
 import * as vscode from 'vscode';
-import { Identity, getIdentitiesWithValidation, resetValidationNotificationFlag } from '../identity/identity';
+import { Identity, getIdentitiesWithValidation, invalidateIdentityCache } from '../identity/identity';
 import { createStatusBar, IdentityStatusBar } from '../ui/identityStatusBar';
 import { showDocumentation } from '../ui/documentationPublic';
 import { securityLogger } from '../security/securityLogger';
@@ -169,7 +169,7 @@ async function performTrustedInitialization(context: vscode.ExtensionContext): P
           }
         }
 
-        resetValidationNotificationFlag();
+        invalidateIdentityCache();
         initializeState(context)
           .then(() => performSyncCheck())
           .catch(error => {

extensions/git-id-switcher/src/core/gitConfig.ts

@@ -14,7 +14,7 @@
 // Type-only import for TypeScript (stripped at compile time)
 import type * as vscodeTypes from 'vscode';
 import { getVSCode, getWorkspace } from './vscodeLoader';
-import { Identity, formatGitAuthor, getIdentitiesWithValidation } from '../identity/identity';
+import { Identity, getIdentitiesWithValidation } from '../identity/identity';
 import { gitExec, secureExec } from '../security/secureExec';
 import { validateIdentity } from '../identity/inputValidator';
 import {
@@ -290,24 +290,6 @@ export async function detectCurrentIdentity(
   return identities.find(i => i.email === config.userEmail);
 }
 
-/**
- * Get Git author string for commit --author flag
- *
- * @security This function builds a shell-quoted `--author` flag using template literals.
- * The return value MUST be passed as an element of the args array to execFile(),
- * never concatenated into a shell command string. Shell concatenation would enable
- * command injection via crafted identity fields.
- *
- * @deprecated Prefer building the args array directly with `formatGitAuthor()`:
- * ```ts
- * await secureExec('git', ['commit', `--author=${formatGitAuthor(identity)}`]);
- * ```
- * This avoids the embedded double-quotes that are unnecessary when using execFile().
- */
-export function getGitAuthorFlag(identity: Identity): string {
-  return `--author="${formatGitAuthor(identity)}"`;
-}
-
 /**
  * Verify Git is available
  */

extensions/git-id-switcher/src/identity/identity.ts

@@ -37,6 +37,15 @@ import { isUnderSshDirectory } from '../security/pathUtils';
  */
 let hasShownValidationError = false;
 
+/**
+ * Cache for validated identities.
+ *
+ * Invalidated on configuration change via invalidateIdentityCache().
+ * Avoids redundant VS Code config reads + schema validation on every call
+ * (up to MAX_IDENTITIES=1000 validateIdentitySchema() per invocation).
+ */
+let identityCache: Identity[] | null = null;
+
 /**
  * Show one-time validation error notification to user.
  *
@@ -324,6 +333,10 @@ export function getFieldMetadata(key: keyof Identity): FieldMetadata | undefined
  *
  * WARNING: This function does not validate identities.
  * Use getIdentitiesWithValidation() for security-critical code paths.
+ *
+ * NOTE: Always reads from VS Code configuration directly, bypassing the
+ * identity cache. This is intentional for config mutation code paths
+ * (add/delete/update/move) that need the latest raw configuration.
  */
 export function getIdentities(): Identity[] {
   const vs = getVSCode();
@@ -344,6 +357,11 @@ export function getIdentities(): Identity[] {
  * @returns Array of valid identities (invalid ones are filtered out)
  */
 export function getIdentitiesWithValidation(): Identity[] {
+  // Return cached result if available (shallow copy to prevent callers from mutating cache)
+  if (identityCache !== null) {
+    return [...identityCache];
+  }
+
   const vs = getVSCode();
   if (!vs) {
     return [];
@@ -363,8 +381,9 @@ export function getIdentitiesWithValidation(): Identity[] {
     return [];
   }
 
-  // Early return for empty array (valid state)
+  // Early return for empty array (valid state, cache to avoid repeated config reads)
   if (rawIdentities.length === 0) {
+    identityCache = [];
     return [];
   }
 
@@ -376,7 +395,8 @@ export function getIdentitiesWithValidation(): Identity[] {
       `Array length exceeds maximum (${MAX_IDENTITIES})`,
       rawIdentities.length
     );
-    // Return empty array to fail securely
+    // Cache and return empty array to fail securely (avoids repeated security log spam)
+    identityCache = [];
     return [];
   }
 
@@ -426,16 +446,19 @@ export function getIdentitiesWithValidation(): Identity[] {
     showValidationErrorNotification(invalidIndices.length);
   }
 
-  return validIdentities;
+  identityCache = validIdentities;
+  return [...validIdentities];
 }
 
 /**
- * Reset the validation error notification flag
+ * Invalidate the identity cache and reset the validation notification flag.
  *
- * Used when configuration changes to allow re-notification of validation errors.
+ * Must be called on configuration change (onDidChangeConfiguration)
+ * to force re-validation on next getIdentitiesWithValidation() call.
  * Also exposed for testing purposes.
  */
-export function resetValidationNotificationFlag(): void {
+export function invalidateIdentityCache(): void {
+  identityCache = null;
   hasShownValidationError = false;
 }
 

extensions/git-id-switcher/src/identity/inputValidator.ts

@@ -310,8 +310,3 @@ export function isShellSafePath(path: string): boolean {
 
   return true;
 }
-
-/**
- * @deprecated Use `isShellSafePath` instead. This alias will be removed in a future version.
- */
-export const isPathSafe = isShellSafePath;

extensions/git-id-switcher/src/security/commandAllowlist.ts

@@ -10,8 +10,8 @@
 import { validatePathSecurity, isPathArgument } from './pathValidator';
 import { validateCombinedFlags } from './flagValidator';
 
-// Re-export for backwards compatibility
-export { validatePathSecurity, isSecurePath, isPathArgument, SecurePathResult } from './pathValidator';
+// Re-export path security utilities
+export { validatePathSecurity, isPathArgument, SecurePathResult } from './pathValidator';
 export { validateCombinedFlags, CombinedFlagResult } from './flagValidator';
 
 /**

extensions/git-id-switcher/src/security/pathUnicodeDetector.ts

@@ -72,16 +72,6 @@ export const controlCharValidator = createControlCharValidator();
  */
 export const invisibleUnicodeValidator = createInvisibleUnicodeValidator();
 
-/**
- * @deprecated Use `controlCharValidator` instead. This alias will be removed in a future version.
- */
-export const validateNoControlChars = controlCharValidator;
-
-/**
- * @deprecated Use `invisibleUnicodeValidator` instead. This alias will be removed in a future version.
- */
-export const validateNoInvisibleUnicode = invisibleUnicodeValidator;
-
 /**
  * Normalizes Unicode to NFC for consistent comparison
  */