Commit 5d12ba8
fix(ux): improve identity management usability (#241)
* feat(i18n): add UX improvement keys for 17 languages
Add i18n keys for identity management UI improvements:
- Edit button tooltip
- Manage Identities title with gear emoji
- Empty state placeholder message
- Name validation error message
- ID format validation with length parameter
🖥️ IDE: [Cursor](https://cursor.sh)
🔌 Extension: [Claude Code](https://claude.ai/download)
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Model-Raw: claude-opus-4-5-20251101
* feat(ui): implement manage identities UI with inline buttons
- Add showManageIdentitiesQuickPick() with edit/delete inline buttons
- Add ManageIdentitiesResult and ManageIdentityQuickPickItem types
- Change showAddIdentityWizard() to return boolean
- Change showEditIdentityWizard() to accept optional targetIdentity
- Change handleAddIdentity() and handleDeleteIdentity() to return boolean
- Add hasDangerousChars() validation for name input
- Add security logging via logConfigChange()
- Implement manage identities loop structure in handlers
🖥️ IDE: [Cursor](https://cursor.sh)
🔌 Extension: [Claude Code](https://claude.ai/download)
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Model-Raw: claude-opus-4-5-20251101
* feat(ui): implement Esc-to-go-back navigation in identity wizards
- Refactor showAddIdentityWizard() to use state machine pattern
- Refactor showEditIdentityWizard() with field selection loop
- Extract validation functions for reusability
- Add defense-in-depth comments for security validation
- Organize code into logical sections (Types, Validation, UI, Persistence, Wizards)
- Reduce cognitive complexity by extracting helper functions
🖥️ IDE: [Cursor](https://cursor.sh)
🔌 Extension: [Claude Code](https://claude.ai/download)
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Model-Raw: claude-opus-4-5-20251101
* test(git-id-switcher): update E2E tests for Phase 5 UX improvements
- identityPicker.test.ts: Add 14 tests for showManageIdentitiesQuickPick
- Title bar button (add), item buttons (edit/delete)
- Back button behavior, empty state, selection handling
- identityManager.test.ts: Rewrite with 19 tests
- Add Wizard normal flow and Esc-back navigation
- Edit Wizard with targetIdentity and Esc-back
- Security validation (ID, Name, Email inputs)
- handlers.test.ts: Add 8 tests (16 total)
- handleDeleteIdentity with targetIdentity parameter
- handleAddIdentity cancel/success flows
- MAX_IDENTITIES limit, security logging verification
All tests pass successfully.
🖥️ IDE: [Cursor](https://cursor.sh)
🔌 Extension: [Claude Code](https://claude.ai/download)
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Model-Raw: claude-opus-4-5-20251101
* fix(ux): improve identity management usability
- Add inline edit/delete buttons to manage identities menu
- Implement Esc-to-go-back navigation in wizards
- Preserve focus position after edit/delete operations
- Show empty state message when no profiles exist
- Fix magic number lint error with ADD_WIZARD constants
- Update version to 0.15.1
🖥️ IDE: [Cursor](https://cursor.sh)
🔌 Extension: [Claude Code](https://claude.ai/download)
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Model-Raw: claude-opus-4-5-20251101
* test: fix E2E test timeouts and email validation test
- Fix selectPlaceholder/selectIdentity mock to trigger hideCallback after acceptCallback
- Fix email validation test to use getAllValidateInputs instead of getLastValidateInput
🖥️ IDE: [Cursor](https://cursor.sh)
🔌 Extension: [Claude Code](https://claude.ai/download)
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Model-Raw: claude-opus-4-5-20251101
---------
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>1 parent 5033254 commit 5d12ba8
26 files changed
Lines changed: 1873 additions & 625 deletions
File tree
- extensions/git-id-switcher
- l10n
- src
- commands
- test/e2e
- ui
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
10 | 21 | | |
11 | 22 | | |
12 | 23 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
72 | | - | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
73 | 78 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
72 | | - | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
73 | 78 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
72 | | - | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
73 | 78 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
72 | | - | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
73 | 78 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
72 | | - | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
73 | 78 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
72 | | - | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
73 | 78 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
72 | | - | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
73 | 78 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
72 | | - | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
73 | 78 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
72 | | - | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
73 | 78 | | |
0 commit comments