fix: set ignoreFocusOut on all QuickPick dialogs to prevent data loss (#253)

Switching to another application while a QuickPick was open would
dismiss it and discard all entered data. This was most critical in
the new profile creation form where multiple fields could be lost.
Set ignoreFocusOut = true on all 5 QuickPick instances to match
the existing InputBox behavior. Bump version to 0.16.9.

🖥️ IDE: [Cursor](https://cursor.sh)
🔌 Extension: [Claude Code](https://claude.ai/download)


Model-Raw: claude-opus-4-5-20251101

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>

Author: nullvariant

extensions/git-id-switcher/CHANGELOG.md

@@ -7,6 +7,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.16.9] - 2026-02-01
+
+### Fixed
+
+- **All QuickPick dialogs now persist when the editor loses focus**:
+  - Previously, switching to another application (e.g., to copy text) would dismiss the QuickPick and discard all entered data
+  - Set `ignoreFocusOut = true` on all 5 QuickPick instances: new profile form, edit form, profile selector, delete picker, and manage screen
+  - Matches the existing InputBox behavior which already retained focus
+
 ## [0.16.8] - 2026-01-31
 
 ### Changed

extensions/git-id-switcher/package.json

@@ -2,7 +2,7 @@
   "name": "git-id-switcher",
   "displayName": "%extension.displayName%",
   "description": "%extension.description%",
-  "version": "0.16.8",
+  "version": "0.16.9",
   "publisher": "nullvariant",
   "icon": "images/icon.png",
   "engines": {

extensions/git-id-switcher/src/test/e2e/deleteIdentityPicker.test.ts

@@ -65,6 +65,7 @@ function createMockVSCode(options: {
 }) {
   let capturedItems: CapturedQuickPickItem[] = [];
   let capturedPlaceholder = '';
+  let capturedIgnoreFocusOut = false;
   let capturedTitle = '';
   const showWarningMessageCalls: string[] = [];
 
@@ -102,6 +103,8 @@ function createMockVSCode(options: {
           set placeholder(value: string) {
             capturedPlaceholder = value;
           },
+          get ignoreFocusOut() { return capturedIgnoreFocusOut; },
+          set ignoreFocusOut(value: boolean) { capturedIgnoreFocusOut = value; },
           matchOnDescription: false,
           matchOnDetail: false,
           get selectedItems(): T[] {
@@ -145,6 +148,7 @@ function createMockVSCode(options: {
     _getCapturedItems: () => capturedItems,
     _getCapturedPlaceholder: () => capturedPlaceholder,
     _getCapturedTitle: () => capturedTitle,
+    _getCapturedIgnoreFocusOut: () => capturedIgnoreFocusOut,
     _getShowWarningMessageCalls: () => showWarningMessageCalls,
   };
 }
@@ -180,6 +184,20 @@ describe('showDeleteIdentityQuickPick E2E Test Suite', function () {
     });
   });
 
+  describe('Focus Retention', () => {
+    it('should set ignoreFocusOut to prevent dismissal on focus change', async () => {
+      const mockVSCode = createMockVSCode({
+        identities: [TEST_IDENTITIES.work],
+        selectedIdentity: TEST_IDENTITIES.work,
+      });
+      _setMockVSCode(mockVSCode as never);
+
+      await showDeleteIdentityQuickPick();
+
+      assert.strictEqual(mockVSCode._getCapturedIgnoreFocusOut(), true, 'Delete identity QuickPick should have ignoreFocusOut=true');
+    });
+  });
+
   describe('Item Generation', () => {
     it('should create items with correct labels', async () => {
       const mockVSCode = createMockVSCode({

extensions/git-id-switcher/src/test/e2e/handlers.test.ts

@@ -102,6 +102,7 @@ function createMockVSCode(options: {
           title: '',
           placeholder: '',
           buttons: [],
+          ignoreFocusOut: false,
           matchOnDescription: false,
           matchOnDetail: false,
           selectedItems: options.showQuickPickResult ? [{ identity: options.showQuickPickResult }] : [],
@@ -231,6 +232,7 @@ function createAddMockVSCode(options: {
           title: '',
           placeholder: '',
           buttons: [] as unknown[],
+          ignoreFocusOut: false,
           onDidAccept: (callback: () => void) => {
             acceptCallback = callback;
             return { dispose: () => {} };

extensions/git-id-switcher/src/test/e2e/identityManager.test.ts

@@ -119,6 +119,7 @@ function createMockVSCode(options: {
     buttons: unknown[];
     title: string;
     placeholder: string;
+    ignoreFocusOut: boolean;
   }) => void;
   onInputBoxCreated?: (inputBox: {
     buttons: unknown[];
@@ -317,6 +318,7 @@ function createMockVSCode(options: {
         let _title = '';
         let _placeholder = '';
         let _buttons: unknown[] = [];
+        let _ignoreFocusOut = false;
 
         const quickPick = {
           get title() { return _title; },
@@ -325,6 +327,8 @@ function createMockVSCode(options: {
           set placeholder(value: string) { _placeholder = value; },
           get buttons() { return _buttons; },
           set buttons(value: unknown[]) { _buttons = value; },
+          get ignoreFocusOut() { return _ignoreFocusOut; },
+          set ignoreFocusOut(value: boolean) { _ignoreFocusOut = value; },
           get items() { return _items; },
           set items(value: T[]) { _items = value; },
           get selectedItems() { return _selectedItems; },
@@ -338,6 +342,7 @@ function createMockVSCode(options: {
                 buttons: _buttons,
                 title: _title,
                 placeholder: _placeholder,
+                ignoreFocusOut: _ignoreFocusOut,
               });
             }
             // Auto-trigger selection based on test configuration
@@ -911,6 +916,23 @@ describe('identityManager E2E Test Suite', function () {
         }
       });
 
+      it('should set ignoreFocusOut to prevent data loss on focus change', async () => {
+        let capturedIgnoreFocusOut = false;
+
+        const mockVSCode = createMockVSCode({
+          identities: [],
+          quickPickSelections: [undefined],
+          onQuickPickCreated: (quickPick) => {
+            capturedIgnoreFocusOut = quickPick.ignoreFocusOut;
+          },
+        });
+        _setMockVSCode(mockVSCode as never);
+
+        await showAddIdentityForm();
+
+        assert.strictEqual(capturedIgnoreFocusOut, true, 'Add form QuickPick should have ignoreFocusOut=true');
+      });
+
       it('should mark required fields (id, name, email) with asterisk', async () => {
         let capturedItems: unknown[] = [];
 
@@ -1217,6 +1239,25 @@ describe('identityManager E2E Test Suite', function () {
   // ===========================================================================
 
   describe('Edit Identity Form', () => {
+    describe('Focus Retention', () => {
+      it('should set ignoreFocusOut to prevent data loss on focus change', async () => {
+        let capturedIgnoreFocusOut = false;
+
+        const mockVSCode = createMockVSCode({
+          identities: [TEST_IDENTITIES.work],
+          quickPickSelections: [undefined],
+          onQuickPickCreated: (quickPick) => {
+            capturedIgnoreFocusOut = quickPick.ignoreFocusOut;
+          },
+        });
+        _setMockVSCode(mockVSCode as never);
+
+        await showEditProfileFlow(TEST_IDENTITIES.work);
+
+        assert.strictEqual(capturedIgnoreFocusOut, true, 'Edit form QuickPick should have ignoreFocusOut=true');
+      });
+    });
+
     describe('Back Button (Field Selection)', () => {
       it('should have QuickInputButtons.Back in field selection', async () => {
         let capturedButtons: unknown[] = [];

extensions/git-id-switcher/src/test/e2e/identityPicker.test.ts

@@ -85,6 +85,7 @@ function createMockVSCode(options: {
   let capturedPlaceholder = '';
   let capturedTitle = '';
   let capturedButtons: unknown[] = [];
+  let capturedIgnoreFocusOut = false;
   const showWarningMessageCalls: string[] = [];
 
   return {
@@ -131,6 +132,8 @@ function createMockVSCode(options: {
           set activeItems(_value: T[]) {
             // Capture but don't need to track for tests
           },
+          get ignoreFocusOut() { return capturedIgnoreFocusOut; },
+          set ignoreFocusOut(value: boolean) { capturedIgnoreFocusOut = value; },
           matchOnDescription: false,
           matchOnDetail: false,
           get selectedItems(): T[] {
@@ -198,6 +201,7 @@ function createMockVSCode(options: {
     _getCapturedPlaceholder: () => capturedPlaceholder,
     _getCapturedTitle: () => capturedTitle,
     _getCapturedButtons: () => capturedButtons,
+    _getCapturedIgnoreFocusOut: () => capturedIgnoreFocusOut,
     _getShowWarningMessageCalls: () => showWarningMessageCalls,
   };
 }
@@ -233,6 +237,20 @@ describe('showIdentityQuickPick E2E Test Suite', function () {
     });
   });
 
+  describe('Focus Retention', () => {
+    it('should set ignoreFocusOut to prevent dismissal on focus change', async () => {
+      const mockVSCode = createMockVSCode({
+        identities: [TEST_IDENTITIES.work],
+        selectedIdentity: TEST_IDENTITIES.work,
+      });
+      _setMockVSCode(mockVSCode as never);
+
+      await showIdentityQuickPick();
+
+      assert.strictEqual(mockVSCode._getCapturedIgnoreFocusOut(), true, 'Select profile QuickPick should have ignoreFocusOut=true');
+    });
+  });
+
   describe('Item Generation', () => {
     it('should create items with correct labels', async () => {
       const mockVSCode = createMockVSCode({
@@ -461,6 +479,7 @@ function createManageMockVSCode(options: {
   let capturedTitle = '';
   let capturedButtons: unknown[] = [];
   let capturedActiveItems: CapturedManageQuickPickItem[] = [];
+  let capturedIgnoreFocusOut = false;
 
   return {
     workspace: {
@@ -503,6 +522,8 @@ function createManageMockVSCode(options: {
           get activeItems(): T[] {
             return capturedActiveItems as unknown as T[];
           },
+          get ignoreFocusOut() { return capturedIgnoreFocusOut; },
+          set ignoreFocusOut(value: boolean) { capturedIgnoreFocusOut = value; },
           matchOnDescription: false,
           matchOnDetail: false,
           get selectedItems(): T[] {
@@ -604,6 +625,7 @@ function createManageMockVSCode(options: {
     _getCapturedTitle: () => capturedTitle,
     _getCapturedButtons: () => capturedButtons,
     _getCapturedActiveItems: () => capturedActiveItems,
+    _getCapturedIgnoreFocusOut: () => capturedIgnoreFocusOut,
   };
 }
 
@@ -618,6 +640,20 @@ describe('showManageIdentitiesQuickPick E2E Test Suite', function () {
     _resetCache();
   });
 
+  describe('Focus Retention', () => {
+    it('should set ignoreFocusOut to prevent dismissal on focus change', async () => {
+      const mockVSCode = createManageMockVSCode({
+        identities: [TEST_IDENTITIES.work],
+        triggerAction: 'hide',
+      });
+      _setMockVSCode(mockVSCode as never);
+
+      await showManageIdentitiesQuickPick([TEST_IDENTITIES.work]);
+
+      assert.strictEqual(mockVSCode._getCapturedIgnoreFocusOut(), true, 'Manage profiles QuickPick should have ignoreFocusOut=true');
+    });
+  });
+
   describe('Basic UI', () => {
     it('should display items correctly', async () => {
       const mockVSCode = createManageMockVSCode({

extensions/git-id-switcher/src/ui/documentationInternal.ts

@@ -25,7 +25,7 @@ export const DOCUMENT_HASHES: Record<string, string> = {
   'AGENTS.md': '54f16b767e57686b3eb46a2b4aa02b378554cc492c32c49ed96588f6d184b6b8',
   'CODE_OF_CONDUCT.md': 'a5eb286c902437bbe0f6d409894f20e51c172fa869fe2f151bfa388f9d911b54',
   'CONTRIBUTING.md': '4150f8810aec7b2e8eff9f3c69ee1bae1374843f50a812efa6778cba27a833cd',
-  'extensions/git-id-switcher/CHANGELOG.md': '5e0833ce75bf64f50e010d3930eae07a0f7418f6854333b863f1c6a25ebf81be',
+  'extensions/git-id-switcher/CHANGELOG.md': '3b18be1ee2c5d09c0b9c8c4ebdef1380bcad712d627e3d698fe14548080e0cad',
   'extensions/git-id-switcher/docs/ARCHITECTURE.md': 'a12dd717f83b28b648972a826701a29fcfd575e351c487f8c421402f80ac3d25',
   'extensions/git-id-switcher/docs/CONTRIBUTING.md': '7d6ad2bc4d8c838790754cb9df848cb65f9fdce7e1a13e5c965b83a3d5b6378c',
   'extensions/git-id-switcher/docs/DESIGN_PHILOSOPHY.md': 'f9718b61ac161cb466dbc76845688e7acacf4e5fdc4b8b9553269dba4a094f6b',

extensions/git-id-switcher/src/ui/identityManager.ts

@@ -867,6 +867,7 @@ async function executeAddFormLoop(
   const quickPick = vs.window.createQuickPick<AddFormQuickPickItem>();
   quickPick.title = vs.l10n.t('New Profile');
   quickPick.placeholder = vs.l10n.t('Filter...');
+  quickPick.ignoreFocusOut = true;
   quickPick.buttons = [vs.QuickInputButtons.Back];
 
   try {
@@ -994,6 +995,7 @@ async function showFieldSelectionQuickPick(
   const quickPick = vs.window.createQuickPick<FieldQuickPickItem>();
   quickPick.title = vs.l10n.t('Edit Identity: {0}', identity.id);
   quickPick.placeholder = vs.l10n.t('Filter...');
+  quickPick.ignoreFocusOut = true;
   quickPick.buttons = [vs.QuickInputButtons.Back];
   quickPick.items = buildFieldItems(vs, identity, savedField, identityCount);
 

extensions/git-id-switcher/src/ui/identityPicker.ts

@@ -122,6 +122,7 @@ export async function showIdentityQuickPick(
   quickPick.items = allItems;
   quickPick.title = vs.l10n.t('Select Profile');
   quickPick.placeholder = vs.l10n.t('Search profiles...');
+  quickPick.ignoreFocusOut = true;
   quickPick.buttons = [manageButton];
   quickPick.matchOnDescription = true;
   quickPick.matchOnDetail = true;
@@ -243,6 +244,7 @@ export async function showDeleteIdentityQuickPick(
   quickPick.items = items;
   quickPick.title = vs.l10n.t('Delete Identity');
   quickPick.placeholder = vs.l10n.t('Select identity to delete');
+  quickPick.ignoreFocusOut = true;
   quickPick.matchOnDescription = true;
   quickPick.matchOnDetail = true;
 
@@ -349,6 +351,7 @@ export async function showManageIdentitiesQuickPick(
   const quickPick = vs.window.createQuickPick<ManageIdentityQuickPickItem>();
   quickPick.items = items;
   quickPick.title = vs.l10n.t('Manage Profiles');
+  quickPick.ignoreFocusOut = true;
   quickPick.buttons = [vs.QuickInputButtons.Back, addButton];
   quickPick.matchOnDescription = true;
   quickPick.matchOnDetail = true;