fix: only set ignoreFocusOut on form-style QuickPick dialogs (#257)

Profile selector and delete picker are simple one-shot pickers with
no unsaved state. They should follow standard VS Code behavior and
dismiss on focus loss. Form dialogs (new profile, edit, manage) keep
ignoreFocusOut=true to prevent data loss.

🖥️ IDE: [Cursor](https://cursor.sh)
🔌 Extension: [Claude Code](https://claude.ai/download)


Model-Raw: claude-opus-4-5-20251101

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>

Author: nullvariant

extensions/git-id-switcher/CHANGELOG.md

@@ -7,6 +7,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.16.10] - 2026-02-02
+
+### Fixed
+
+- **Profile selector and delete picker now dismiss normally on focus loss**:
+  - v0.16.9 applied `ignoreFocusOut` to all QuickPick dialogs, which prevented simple pickers from being dismissed by clicking outside
+  - Now only form-style dialogs (new profile, edit, manage) retain focus; simple pickers follow standard VS Code behavior
+
 ## [0.16.9] - 2026-02-01
 
 ### Fixed

extensions/git-id-switcher/package.json

@@ -2,7 +2,7 @@
   "name": "git-id-switcher",
   "displayName": "%extension.displayName%",
   "description": "%extension.description%",
-  "version": "0.16.9",
+  "version": "0.16.10",
   "publisher": "nullvariant",
   "icon": "images/icon.png",
   "engines": {

extensions/git-id-switcher/src/test/e2e/deleteIdentityPicker.test.ts

@@ -184,8 +184,8 @@ describe('showDeleteIdentityQuickPick E2E Test Suite', function () {
     });
   });
 
-  describe('Focus Retention', () => {
-    it('should set ignoreFocusOut to prevent dismissal on focus change', async () => {
+  describe('Focus Behavior', () => {
+    it('should not set ignoreFocusOut (simple picker dismisses on focus loss)', async () => {
       const mockVSCode = createMockVSCode({
         identities: [TEST_IDENTITIES.work],
         selectedIdentity: TEST_IDENTITIES.work,
@@ -194,7 +194,7 @@ describe('showDeleteIdentityQuickPick E2E Test Suite', function () {
 
       await showDeleteIdentityQuickPick();
 
-      assert.strictEqual(mockVSCode._getCapturedIgnoreFocusOut(), true, 'Delete identity QuickPick should have ignoreFocusOut=true');
+      assert.strictEqual(mockVSCode._getCapturedIgnoreFocusOut(), false, 'Delete identity QuickPick should not set ignoreFocusOut');
     });
   });
 

extensions/git-id-switcher/src/test/e2e/identityPicker.test.ts

@@ -237,8 +237,8 @@ describe('showIdentityQuickPick E2E Test Suite', function () {
     });
   });
 
-  describe('Focus Retention', () => {
-    it('should set ignoreFocusOut to prevent dismissal on focus change', async () => {
+  describe('Focus Behavior', () => {
+    it('should not set ignoreFocusOut (simple picker dismisses on focus loss)', async () => {
       const mockVSCode = createMockVSCode({
         identities: [TEST_IDENTITIES.work],
         selectedIdentity: TEST_IDENTITIES.work,
@@ -247,7 +247,7 @@ describe('showIdentityQuickPick E2E Test Suite', function () {
 
       await showIdentityQuickPick();
 
-      assert.strictEqual(mockVSCode._getCapturedIgnoreFocusOut(), true, 'Select profile QuickPick should have ignoreFocusOut=true');
+      assert.strictEqual(mockVSCode._getCapturedIgnoreFocusOut(), false, 'Select profile QuickPick should not set ignoreFocusOut');
     });
   });
 

extensions/git-id-switcher/src/ui/documentationInternal.ts

@@ -25,7 +25,7 @@ export const DOCUMENT_HASHES: Record<string, string> = {
   'AGENTS.md': '54f16b767e57686b3eb46a2b4aa02b378554cc492c32c49ed96588f6d184b6b8',
   'CODE_OF_CONDUCT.md': 'a5eb286c902437bbe0f6d409894f20e51c172fa869fe2f151bfa388f9d911b54',
   'CONTRIBUTING.md': '4150f8810aec7b2e8eff9f3c69ee1bae1374843f50a812efa6778cba27a833cd',
-  'extensions/git-id-switcher/CHANGELOG.md': '3b18be1ee2c5d09c0b9c8c4ebdef1380bcad712d627e3d698fe14548080e0cad',
+  'extensions/git-id-switcher/CHANGELOG.md': 'b5bf6fb072263ef4a2c512cf583c31c9fbf3ab19ceb637304548bc4ff5cae6e1',
   'extensions/git-id-switcher/docs/ARCHITECTURE.md': 'a12dd717f83b28b648972a826701a29fcfd575e351c487f8c421402f80ac3d25',
   'extensions/git-id-switcher/docs/CONTRIBUTING.md': '7d6ad2bc4d8c838790754cb9df848cb65f9fdce7e1a13e5c965b83a3d5b6378c',
   'extensions/git-id-switcher/docs/DESIGN_PHILOSOPHY.md': 'f9718b61ac161cb466dbc76845688e7acacf4e5fdc4b8b9553269dba4a094f6b',

extensions/git-id-switcher/src/ui/identityPicker.ts

@@ -122,7 +122,6 @@ export async function showIdentityQuickPick(
   quickPick.items = allItems;
   quickPick.title = vs.l10n.t('Select Profile');
   quickPick.placeholder = vs.l10n.t('Search profiles...');
-  quickPick.ignoreFocusOut = true;
   quickPick.buttons = [manageButton];
   quickPick.matchOnDescription = true;
   quickPick.matchOnDetail = true;
@@ -244,7 +243,6 @@ export async function showDeleteIdentityQuickPick(
   quickPick.items = items;
   quickPick.title = vs.l10n.t('Delete Identity');
   quickPick.placeholder = vs.l10n.t('Select identity to delete');
-  quickPick.ignoreFocusOut = true;
   quickPick.matchOnDescription = true;
   quickPick.matchOnDetail = true;