Skip to content

Commit d1055ac

Browse files
nullvariantclaude
andauthored
fix: use codicon in label for consistent icon display (#246)
- Manage Profiles: use $(gear) in label instead of iconPath (iconPath only shows on hover without item buttons) - Save button disabled: use $(session-in-progress) static icon instead of $(loading~spin) animated spinner 🖥️ IDE: [Cursor](https://cursor.sh) 🔌 Extension: [Claude Code](https://claude.ai/download) Model-Raw: claude-opus-4-5-20251101 Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
1 parent 8dbd56f commit d1055ac

7 files changed

Lines changed: 15 additions & 8 deletions

File tree

extensions/git-id-switcher/CHANGELOG.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
77

88
## [Unreleased]
99

10+
## [0.16.2] - 2026-01-28
11+
12+
### Fixed
13+
14+
- **Manage Profiles icon not visible without hover**:
15+
- Use Codicon in label `$(gear)` instead of iconPath for consistent display
16+
- **Save button disabled state icon**:
17+
- Changed from `$(loading~spin)` to `$(session-in-progress)` (static icon)
18+
1019
## [0.16.1] - 2026-01-28
1120

1221
### Fixed

extensions/git-id-switcher/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "git-id-switcher",
33
"displayName": "%extension.displayName%",
44
"description": "%extension.description%",
5-
"version": "0.16.1",
5+
"version": "0.16.2",
66
"publisher": "nullvariant",
77
"icon": "images/icon.png",
88
"engines": {

extensions/git-id-switcher/src/test/e2e/identityManager.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1019,7 +1019,7 @@ describe('identityManager E2E Test Suite', function () {
10191019
);
10201020
assert.ok(saveButton, 'Save button should be present');
10211021
const label = (saveButton as { label: string }).label;
1022-
assert.ok(label.includes('$(loading~spin)'), `Save button should show $(loading~spin) when disabled, got: ${label}`);
1022+
assert.ok(label.includes('$(session-in-progress)'), `Save button should show $(session-in-progress) when disabled, got: ${label}`);
10231023
assert.strictEqual((saveButton as { _isDisabled?: boolean })._isDisabled, true, 'Save button should be disabled');
10241024
});
10251025

extensions/git-id-switcher/src/test/e2e/identityPicker.test.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -292,8 +292,7 @@ describe('showIdentityQuickPick E2E Test Suite', function () {
292292
const manageItem = items.find(item => item._isManageOption === true);
293293
assert.ok(manageItem, 'Should have manage option');
294294
assert.ok(manageItem.label.includes('Manage'), 'Manage label should mention Manage');
295-
assert.ok(manageItem.iconPath, 'Manage option should have iconPath');
296-
assert.strictEqual(manageItem.iconPath?.id, 'gear', 'Manage option should have gear icon');
295+
assert.ok(manageItem.label.includes('$(gear)'), 'Manage label should include gear icon codicon');
297296
});
298297
});
299298

extensions/git-id-switcher/src/ui/documentationInternal.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ export const DOCUMENT_HASHES: Record<string, string> = {
2525
'AGENTS.md': '54f16b767e57686b3eb46a2b4aa02b378554cc492c32c49ed96588f6d184b6b8',
2626
'CODE_OF_CONDUCT.md': 'a5eb286c902437bbe0f6d409894f20e51c172fa869fe2f151bfa388f9d911b54',
2727
'CONTRIBUTING.md': '4150f8810aec7b2e8eff9f3c69ee1bae1374843f50a812efa6778cba27a833cd',
28-
'extensions/git-id-switcher/CHANGELOG.md': 'aee584f2ba3bd1b43b645997073c12379be379e4f7b6c6a3e54cb41ffdb822fb',
28+
'extensions/git-id-switcher/CHANGELOG.md': '8731d6c5a1db51f4ac4084558f1ad5196a8bd54070fa97bc29f79766d281e3f1',
2929
'extensions/git-id-switcher/docs/ARCHITECTURE.md': 'a12dd717f83b28b648972a826701a29fcfd575e351c487f8c421402f80ac3d25',
3030
'extensions/git-id-switcher/docs/CONTRIBUTING.md': '7d6ad2bc4d8c838790754cb9df848cb65f9fdce7e1a13e5c965b83a3d5b6378c',
3131
'extensions/git-id-switcher/docs/DESIGN_PHILOSOPHY.md': 'f9718b61ac161cb466dbc76845688e7acacf4e5fdc4b8b9553269dba4a094f6b',

extensions/git-id-switcher/src/ui/identityManager.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -520,7 +520,7 @@ function buildAddFormItems(
520520
items.push({
521521
label: canSave
522522
? `$(check) ${vs.l10n.t('Save')}`
523-
: `$(loading~spin) ${vs.l10n.t('Save')}`,
523+
: `$(session-in-progress) ${vs.l10n.t('Save')}`,
524524
description: canSave
525525
? undefined
526526
: vs.l10n.t('(fill required fields)'),

extensions/git-id-switcher/src/ui/identityPicker.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,7 @@ export async function showIdentityQuickPick(
103103
} as IdentityQuickPickItem;
104104

105105
const manageItem: IdentityQuickPickItem = {
106-
label: vs.l10n.t('Manage Profiles'),
107-
iconPath: new vs.ThemeIcon('gear'),
106+
label: `$(gear) ${vs.l10n.t('Manage Profiles')}`,
108107
identity: null as unknown as Identity,
109108
_isManageOption: true,
110109
};

0 commit comments

Comments
 (0)