refactor(git-id-switcher): design tokens round two — body tokens + pad→size rename#463
Conversation
… --gis-pad-* to --gis-size-* Add six new design tokens to :root (--gis-width-readable, --gis-line-height-doc, --gis-border-emphasis, --gis-pad-code, --gis-spinner-size, --gis-spinner-border) and rename --gis-pad-btn/body/body-lg to --gis-size-btn/body/body-lg to reflect their mixed padding/margin usage. Replace all remaining magic numbers in document/loading/error templates with token references. Extend tokenSpec value contracts and add SSOT literal check for --gis-border-emphasis. Signed-off-by: Null;Variant <null@nullvariant.com> 🖥️ IDE: [VS Code](https://code.visualstudio.com/) 🔌 Extension: [Claude Code](https://claude.ai/download) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Model-Raw: claude-opus-4-6
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
🐰 Mimi's Validation Report ✅All checks are looking good! Great job! 🎉 ⏳ Some checks are still running. I will keep watching!
This report was carefully prepared by nullvariant-mimi[bot] |
🦥 Slow's Code Review 😩...yawn... Do I really have to review this?
| Split it up... reading long files is exhausting.
This review was reluctantly filed by nullvariant-slow[bot] |
🕊️ Ciel's Mediation 🌤️*~~ floating down from the clouds ~~ The zoo seems a bit noisy today...* 4 zoo members have reviewed this PR.
⚖️ The zoo has mixed opinions. Some are concerned, some are fine with it. Please review each comment carefully and make the final call.
This mediation was peacefully delivered by nullvariant-ciel[bot] |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![nullvariant-justice[bot]](https://avatars.githubusercontent.com/in/2610732?s=60&v=4){kind=small}
Signed-off-by: Null;Variant <null@nullvariant.com> 🖥️ IDE: [VS Code](https://code.visualstudio.com/) 🔌 Extension: [Claude Code](https://claude.ai/download) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Model-Raw: claude-opus-4-6
👧 Luna's Exploration Report 📦No new dependencies added. Just version bumps! Nothing to explore here... 😴
This report was curiously compiled by nullvariant-luna[bot] |
🐗 Blaze's Release Review 🔥🔥🔥🔥 VERSION BUMP DETECTED! THIS IS IT! 🔥🔥🔥 🔥 MINOR VERSION BUMP in
🔥 New features incoming! Make sure:
This review was ENTHUSIASTICALLY filed by nullvariant-blaze[bot] |
|
1 participant
Summary
:root—--gis-width-readable,--gis-line-height-doc,--gis-border-emphasis,--gis-pad-code,--gis-spinner-size,--gis-spinner-border--gis-pad-btn/body/body-lg→--gis-size-btn/body/body-lgto reflect mixed padding/margin usagetokenSpecvalue contracts and add SSOT literal check for--gis-border-emphasisTest plan
npx tsc --noEmit)--max-warnings=0npm run test:coverage)--gis-pad-references (except new--gis-pad-code)