nit: update variable names

Signed-off-by: adarsh0728 <gooneriitk@gmail.com>

Author: adarsh0728

pynumaflow/_constants.py

@@ -9,8 +9,8 @@
 
 # Error Constants
 RUNTIME_APPLICATION_ERRORS_PATH = "/var/numaflow/runtime/application-errors"
-CURRENT_FILE = "current-udf.json"
-INTERNAL_ERROR = "Internal error"
+CURRENT_CRITICAL_ERROR_FILE = "current-udf.json"
+INTERNAL_ERROR_CODE = "Internal error"
 CONTAINER_TYPE = os.getenv(ENV_UD_CONTAINER_TYPE, "unknown-container")
 ERR_UDF_EXCEPTION_STRING = f"UDF_EXECUTION_ERROR({CONTAINER_TYPE})"
 

pynumaflow/errors/errors.py

@@ -5,8 +5,8 @@
 from pynumaflow._constants import (
     CONTAINER_TYPE,
     RUNTIME_APPLICATION_ERRORS_PATH,
-    CURRENT_FILE,
-    INTERNAL_ERROR,
+    CURRENT_CRITICAL_ERROR_FILE,
+    INTERNAL_ERROR_CODE,
 )
 from pynumaflow.errors._dtypes import _RuntimeErrorEntry
 from typing import Union
@@ -62,8 +62,8 @@ def _persist_critical_error_to_file(
     container_dir = os.path.join(dir_path, CONTAINER_TYPE)
     os.makedirs(container_dir, mode=0o777, exist_ok=True)
 
-    current_file_path = os.path.join(container_dir, CURRENT_FILE)
-    error_code = error_code or INTERNAL_ERROR
+    current_file_path = os.path.join(container_dir, CURRENT_CRITICAL_ERROR_FILE)
+    error_code = error_code or INTERNAL_ERROR_CODE
     current_timestamp = int(time.time())
 
     runtime_error_entry = _RuntimeErrorEntry(

tests/errors/test_persist_critical_error.py

@@ -5,7 +5,7 @@
 import unittest
 from pynumaflow.errors.errors import persist_critical_error, _persist_error_once
 from pynumaflow.errors.errors import _persist_critical_error_to_file
-from pynumaflow._constants import CONTAINER_TYPE, INTERNAL_ERROR
+from pynumaflow._constants import CONTAINER_TYPE, INTERNAL_ERROR_CODE
 
 
 class TestErrorPersistence(unittest.TestCase):
@@ -75,7 +75,7 @@ def test_uses_default_error_code_if_none_provided(self):
 
         with open(os.path.join(container_dir, files[0])) as f:
             error_data = json.load(f)
-            self.assertEqual(error_data["code"], INTERNAL_ERROR)
+            self.assertEqual(error_data["code"], INTERNAL_ERROR_CODE)
 
     def test_persist_critical_error_all_threads_fail(self):
         """