Skip to content

fix: Clean shutdown for Sink threaded server using threading.Event#325

Merged
BulkBeing merged 7 commits into
mainfrom
sink-threaded-clean-shutdown
Mar 5, 2026
Merged

fix: Clean shutdown for Sink threaded server using threading.Event#325
BulkBeing merged 7 commits into
mainfrom
sink-threaded-clean-shutdown

lints

20d00d5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 5, 2026 in 0s

94.24% (-0.23%) compared to 23bc5d0

View this Pull Request on Codecov

94.24% (-0.23%) compared to 23bc5d0

Details

Codecov Report

❌ Patch coverage is 91.66667% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.24%. Comparing base (23bc5d0) to head (20d00d5).

Files with missing lines Patch % Lines
packages/pynumaflow/pynumaflow/sinker/server.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #325      +/-   ##
==========================================
- Coverage   94.46%   94.24%   -0.23%     
==========================================
  Files          66       66              
  Lines        3071     3092      +21     
  Branches      158      162       +4     
==========================================
+ Hits         2901     2914      +13     
- Misses        141      148       +7     
- Partials       29       30       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.