Skip to content

Commit 08145dd

Browse files
fix: option to skip main image rebuilds during make Test% (#3446)
Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
1 parent 51b7026 commit 08145dd

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

Makefile

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,10 +153,15 @@ cleanup-e2e:
153153
kubectl -n numaflow-system delete po -lnumaflow-e2e=true --ignore-not-found=true
154154

155155
# To run just one of the e2e tests by name (i.e. 'make TestCreateSimplePipeline'):
156+
# Set SKIP_IMAGE_BUILD=true to skip rebuilding the main image and restarting the
157+
# controller-manager pod (useful for iterative test runs when only test code changed).
156158
Test%:
157159
$(MAKE) cleanup-e2e
158-
$(MAKE) image e2eapi-image
160+
ifndef SKIP_IMAGE_BUILD
161+
$(MAKE) image
159162
kubectl -n numaflow-system delete po -lapp.kubernetes.io/component=controller-manager,app.kubernetes.io/part-of=numaflow
163+
endif
164+
$(MAKE) e2eapi-image
160165
kubectl -n numaflow-system delete po e2e-api-pod --ignore-not-found=true
161166
go generate $(shell find $(shell grep -rl $(*) ./test/*-e2e/*.go))
162167
cat test/manifests/e2e-api-pod.yaml | sed 's@quay.io/numaproj/@$(IMAGE_NAMESPACE)/@' | sed 's/:latest/:$(VERSION)/' | kubectl -n numaflow-system apply -f -

0 commit comments

Comments
 (0)