feat: add reduce metrics for rust data plane#3364
Open
adarsh0728 wants to merge 5 commits intomainfrom
Open
Conversation
Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3364 +/- ##
==========================================
- Coverage 82.53% 82.51% -0.03%
==========================================
Files 307 307
Lines 75325 75517 +192
==========================================
+ Hits 62172 62313 +141
- Misses 12595 12649 +54
+ Partials 558 555 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: adarsh0728 <gooneriitk@gmail.com> # Conflicts: # rust/numaflow-core/src/reduce/pbq.rs
Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Metrics Added
reduce_active_windowsreduce_closed_windowsreduce_watermark_lagreduce_window_processing_timereduce_pnf_process_timereduce_pbq_writeWatermark exposed as lag, not raw epoch —
wall_clock - watermarkin milliseconds is directly alertable (e.g., "lag > 5min")Updated metrics.md as well
Related issues
Fixes #3234
Testing
Test Pipelines
Aligned (Fixed Window) — even-odd-sum Pipeline
Total inputs sent: 101 messages (1 priming + 100 batch)
reduce_pbq_write_totalreduce_active_windowsreduce_closed_windowsreduce_watermark_lagreduce_window_processing_timereduce_pnf_process_timeUnaligned (Session Window) — simple-session-counter Pipeline
Total inputs sent: 101 messages (1 priming + 100 batch)
After 60s idle: counter stays at 101 — no WMB inflation.
reduce_pbq_write_totalreduce_active_windowsreduce_closed_windowsreduce_watermark_lagmaxDelay: 30sconfigreduce_window_processing_timereduce_pnf_process_time