feat: add OTLP export into tracing setup with context propagation helpers#3385
feat: add OTLP export into tracing setup with context propagation helpers#3385
Conversation
Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3385 +/- ##
==========================================
- Coverage 82.55% 81.23% -1.33%
==========================================
Files 306 307 +1
Lines 74445 78064 +3619
==========================================
+ Hits 61460 63415 +1955
- Misses 12427 14094 +1667
+ Partials 558 555 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
|
Opentelemetry's general recommendation is to have sampling if we generate more than 1000 traces per second. |
Signed-off-by: Vigith Maurice <vigith@gmail.com>
Signed-off-by: Vigith Maurice <vigith@gmail.com>
Signed-off-by: Vigith Maurice <vigith@gmail.com>
…lp_layer does it anyways Signed-off-by: Vigith Maurice <vigith@gmail.com>
vigith
left a comment
There was a problem hiding this comment.
I have pushed some changes, please review, and feel free to revert it. I made "a change" per commit.
Could you please improve the test coverage?
Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
What this PR does / why we need it
OTEL_EXPORTER_OTLP_ENDPOINTenv var is set.OTEL_TRACES_SAMPLER&&OTEL_TRACES_SAMPLER_ARGcan be configured for samplingRelated issues
Fixes #3378
Testing
Deploy with OTEL_EXPORTER_OTLP_ENDPOINT pointed at Jaeger — verified there are no crashes, exporter connects
Spec used
Special notes for reviewers