feat: source-transformer-map-sink spans#3390
Closed
adarsh0728 wants to merge 6 commits intomainfrom
Closed
Conversation
Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
vigith
reviewed
Apr 22, 2026
|
|
||
| // Drop span guard now so spans are closed before returning. They will also close on any | ||
| // early-return from the error branch below. | ||
| drop(_span_guard); |
Member
There was a problem hiding this comment.
you do not require this because i have added a drop guard on the other one.
Member
Author
|
Will create a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
numaflow.platform.processroot spannumaflow.monovertex.source.dispatchto measure source-stage worknumaflow.monovertex.source.transformfor source-transformer UDF timenumaflow.monovertex.mapandnumaflow.monovertex.sink.writeunder the same root spanFan-out Handling
This PR explicitly handles the source-transformer 1->N case:
platform.processis still created once per source input.source.transformis still created once per source input.source.dispatchstays open until the final emitted child message for that source input is dispatched/bypassed downstream.Note
numaflow.platform.processcreated insourceonce a message exists, i.e. afterSelf::read()returns and before tracker insertion.source.readspan.source.dispatchoperation name can be changed if required.Related issues
Fixes #3379
Testing
In Progress
Special notes for reviewers
Will change the base to main once
tracing-basebranch PR is merged