Skip to content

feat: isb spans for tracing#3437

Draft
adarsh0728 wants to merge 4 commits into
mainfrom
isb-spans
Draft

feat: isb spans for tracing#3437
adarsh0728 wants to merge 4 commits into
mainfrom
isb-spans

Conversation

@adarsh0728
Copy link
Copy Markdown
Member

What this PR does / why we need it

ISB spans for tracing

Related issues

Fixes #3380

Testing

Screenshot 2026-05-18 at 9 52 19 AM

Special notes for reviewers

Anything notable for review (risk, rollout, follow-ups).

Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

❌ Patch coverage is 84.64052% with 47 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.64%. Comparing base (d8f9522) to head (f820238).

Files with missing lines Patch % Lines
rust/numaflow-core/src/shared/otel.rs 84.16% 41 Missing ⚠️
rust/numaflow-core/src/message.rs 60.00% 2 Missing ⚠️
rust/numaflow-core/src/source.rs 83.33% 2 Missing ⚠️
rust/numaflow/src/setup_tracing.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3437      +/-   ##
==========================================
+ Coverage   82.54%   82.64%   +0.09%     
==========================================
  Files         307      307              
  Lines       77306    77531     +225     
==========================================
+ Hits        63816    64078     +262     
+ Misses      12935    12895      -40     
- Partials      555      558       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
Avoid reusing the production cached tracer in tests so full-suite runs do not
depend on which test initializes the global OTel provider first. Keep production
tracer caching unchanged while allowing tests to use the current test provider.

Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OTel tracing ISB spans for Pipeline

1 participant