Skip to content

feat: per msg nack option wiring for source and isb#3455

Draft
vaibhavtiwari33 wants to merge 3 commits into
mainfrom
per-msg-nack
Draft

feat: per msg nack option wiring for source and isb#3455
vaibhavtiwari33 wants to merge 3 commits into
mainfrom
per-msg-nack

Conversation

@vaibhavtiwari33
Copy link
Copy Markdown
Contributor

What this PR does / why we need it

  • Introduce per message nack options
  • Wire the options into source and ISB

Related issues

Fixes #3112
Fixes #3113

Testing

  • Pending unit tests

Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
@vaibhavtiwari33 vaibhavtiwari33 self-assigned this Jun 4, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2026

Codecov Report

❌ Patch coverage is 65.02732% with 64 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.64%. Comparing base (38f3306) to head (f18c3c3).

Files with missing lines Patch % Lines
rust/numaflow-core/src/message.rs 60.34% 23 Missing ⚠️
rust/numaflow-core/src/pipeline/isb/reader.rs 60.00% 6 Missing ⚠️
rust/numaflow-core/src/source/generator.rs 16.66% 5 Missing ⚠️
rust/numaflow-core/src/source/kafka.rs 16.66% 5 Missing ⚠️
rust/numaflow-core/src/source/nats.rs 16.66% 5 Missing ⚠️
rust/numaflow-core/src/source/pulsar.rs 16.66% 5 Missing ⚠️
rust/numaflow-core/src/source/sqs.rs 16.66% 5 Missing ⚠️
rust/numaflow-core/src/pipeline/isb/writer.rs 72.72% 3 Missing ⚠️
rust/numaflow-core/src/mapper/map.rs 81.81% 2 Missing ⚠️
rust/numaflow-core/src/monovertex/bypass_router.rs 66.66% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3455      +/-   ##
==========================================
+ Coverage   82.55%   82.64%   +0.09%     
==========================================
  Files         307      307              
  Lines       77618    77686      +68     
==========================================
+ Hits        64077    64207     +130     
+ Misses      12984    12919      -65     
- Partials      557      560       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vaibhavtiwari33 vaibhavtiwari33 requested a review from syayi June 4, 2026 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ISB changes to support Per-Message Nack Source changes to support Per-Message Nack

1 participant