Merge pull request #3387 from numbersprotocol/copilot/add-content-security-policy-error-handling

Add Content Security Policy and fix silent error swallowing in subscribe calls

Author: olgahaha

src/app/features/contacts/contacts.page.ts

@@ -46,7 +46,10 @@ export class ContactsPage {
         catchError((err: unknown) => this.errorService.toastError$(err)),
         untilDestroyed(this)
       )
-      .subscribe();
+      .subscribe({
+        // eslint-disable-next-line no-console
+        error: (err: unknown) => console.error(err),
+      });
   }
 
   // eslint-disable-next-line class-methods-use-this

src/app/features/data-policy/data-policy.page.ts

@@ -44,6 +44,9 @@ export class DataPolicyPage {
         }),
         untilDestroyed(this)
       )
-      .subscribe();
+      .subscribe({
+        // eslint-disable-next-line no-console
+        error: (err: unknown) => console.error(err),
+      });
   }
 }

src/app/features/signup/signup.page.ts

@@ -70,7 +70,10 @@ export class SignupPage {
         ),
         untilDestroyed(this)
       )
-      .subscribe();
+      .subscribe({
+        // eslint-disable-next-line no-console
+        error: (err: unknown) => console.error(err),
+      });
   }
 
   private createFormFields(
@@ -237,7 +240,10 @@ export class SignupPage {
     this.blockingActionService
       .run$(action$)
       .pipe(untilDestroyed(this))
-      .subscribe();
+      .subscribe({
+        // eslint-disable-next-line no-console
+        error: (err: unknown) => console.error(err),
+      });
   }
 
   private handleOnSubmitError(err: unknown) {

src/app/features/wallets/transfer/transfer.page.ts

@@ -65,9 +65,13 @@ export class TransferPage {
     private readonly platform: Platform,
     private readonly snackBar: MatSnackBar
   ) {
-    this.activeRoute.paramMap.subscribe(paramMap => {
-      // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
-      this.mode = paramMap.get('mode')!;
+    this.activeRoute.paramMap.subscribe({
+      next: paramMap => {
+        // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+        this.mode = paramMap.get('mode')!;
+      },
+      // eslint-disable-next-line no-console
+      error: (err: unknown) => console.error(err),
     });
   }
 
@@ -84,7 +88,10 @@ export class TransferPage {
         ),
         untilDestroyed(this)
       )
-      .subscribe();
+      .subscribe({
+        // eslint-disable-next-line no-console
+        error: (err: unknown) => console.error(err),
+      });
   }
 
   onInputTransferAmount() {
@@ -98,7 +105,10 @@ export class TransferPage {
           this.translocoService.translate('error.wallets.emptyTransferAmount')
         )
         .pipe(untilDestroyed(this))
-        .subscribe();
+        .subscribe({
+          // eslint-disable-next-line no-console
+          error: (err: unknown) => console.error(err),
+        });
       return;
     }
 
@@ -156,7 +166,10 @@ export class TransferPage {
         }),
         untilDestroyed(this)
       )
-      .subscribe();
+      .subscribe({
+        // eslint-disable-next-line no-console
+        error: (err: unknown) => console.error(err),
+      });
   }
 
   transfer() {
@@ -180,7 +193,10 @@ export class TransferPage {
         finalize(() => dialogRef.close()),
         untilDestroyed(this)
       )
-      .subscribe();
+      .subscribe({
+        // eslint-disable-next-line no-console
+        error: (err: unknown) => console.error(err),
+      });
   }
 
   openTransferRequestSentDialog() {

src/app/features/wallets/wallets.page.ts

@@ -90,7 +90,10 @@ export class WalletsPage {
         }),
         untilDestroyed(this)
       )
-      .subscribe();
+      .subscribe({
+        // eslint-disable-next-line no-console
+        error: (err: unknown) => console.error(err),
+      });
   }
 
   private reloadPage() {
@@ -103,7 +106,10 @@ export class WalletsPage {
         }),
         untilDestroyed(this)
       )
-      .subscribe();
+      .subscribe({
+        // eslint-disable-next-line no-console
+        error: (err: unknown) => console.error(err),
+      });
   }
 
   private copyToClipboardAssetWallet() {
@@ -113,7 +119,10 @@ export class WalletsPage {
         concatMap(assetWalletAddr => this.copyToClipboard(assetWalletAddr)),
         untilDestroyed(this)
       )
-      .subscribe();
+      .subscribe({
+        // eslint-disable-next-line no-console
+        error: (err: unknown) => console.error(err),
+      });
   }
 
   private copyToClipboardIntegrityWallet() {
@@ -123,7 +132,10 @@ export class WalletsPage {
         concatMap(publicKey => this.copyToClipboard(publicKey)),
         untilDestroyed(this)
       )
-      .subscribe();
+      .subscribe({
+        // eslint-disable-next-line no-console
+        error: (err: unknown) => console.error(err),
+      });
   }
 
   private copyToClipboardPrivateKey() {
@@ -133,7 +145,10 @@ export class WalletsPage {
         concatMap(privateKey => this.copyToClipboard(privateKey)),
         untilDestroyed(this)
       )
-      .subscribe();
+      .subscribe({
+        // eslint-disable-next-line no-console
+        error: (err: unknown) => console.error(err),
+      });
   }
 
   navigateToBuyNumPage() {