Skip to content

Fix open redirect vulnerability in action-details via URL allowlist validation #3397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olgahaha merged 6 commits into from
Apr 16, 2026
Merged

Fix open redirect vulnerability in action-details via URL allowlist validation #3397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ad86347
Initial plan
Copilot Apr 2, 2026
92fa759
Fix open redirect vulnerability in action-details page with URL allow…
Copilot Apr 2, 2026
7abf499
fix: use fakeAsync+tick in positive redirect tests for async observable
Apr 16, 2026
adba4a1
test: override id$ and remove fakeAsync from action-details tests
Apr 16, 2026
7e85827
refactor: remove redirectToExternalUrl feature
Apr 16, 2026
bb5e179
Merge branch 'main' into copilot/fix-open-redirect-vulnerability
olgahaha Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 0 additions & 29 deletions src/app/features/home/details/actions/action-details/action-details.page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import { UntypedFormGroup } from '@angular/forms';
import { MatDialog } from '@angular/material/dialog';
import { MatSnackBar } from '@angular/material/snack-bar';
import { ActivatedRoute, Router } from '@angular/router';
import { Browser } from '@capacitor/browser';
import { NavController } from '@ionic/angular';
import { TranslocoService } from '@jsverse/transloco';
import { UntilDestroy, untilDestroyed } from '@ngneat/until-destroy';
Expand Down Expand Up @@ -43,7 +42,6 @@ import { DiaBackendWalletService } from '../../../../../shared/dia-backend/walle
import { ErrorService } from '../../../../../shared/error/error.service';
import { OrderDetailDialogComponent } from '../../../../../shared/order-detail-dialog/order-detail-dialog.component';
import { ProofRepository } from '../../../../../shared/repositories/proof/proof-repository.service';
import { browserToolbarColor } from '../../../../../utils/constants';
import {
VOID$,
isNonNullable,
Expand Down Expand Up @@ -325,14 +323,6 @@ export class ActionDetailsPage {
this.navController.back();
}
}),
tap(networkAppOrder => {
if (action.ext_action_destination_text) {
this.redirectToExternalUrl(
action.ext_action_destination_text,
networkAppOrder.id
);
}
}),
untilDestroyed(this)
);
})
Expand Down Expand Up @@ -371,25 +361,6 @@ export class ActionDetailsPage {
);
}

redirectToExternalUrl(url: string, orderId: string) {
this.id$
.pipe(
first(),
isNonNullable(),
tap(cid =>
Browser.open({
url: `${url}?cid=${cid}&order_id=${orderId}`,
toolbarColor: browserToolbarColor,
})
),
catchError((err: unknown) => {
return this.errorService.toastError$(err);
}),
untilDestroyed(this)
)
.subscribe();
}

removeCaptureAndNavigateHome() {
if (this.informationSessionService.activatedDetailedCapture) {
this.informationSessionService.activatedDetailedCapture.proof$.subscribe(
Expand Down
1 change: 0 additions & 1 deletion src/app/shared/actions/service/actions.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ export interface Action {
readonly params_list_custom_param1?: string[];
readonly title_text: string;
readonly network_app_id_text: string;
readonly ext_action_destination_text?: string;
readonly hide_capture_after_execution_boolean?: boolean;
}

Expand Down
Loading