Performance and error-handling improvements across shared services

[Copilot]

Six medium-priority issues across shared services: unnecessary change detection cycles, repeated timestamp computation, TOCTOU race in preference initialization, mutex contention during large file writes, a silently swallowed auth error, and no upload recovery signal on reconnection.

Changes

• CaptureTabComponent — Added ChangeDetectionStrategy.OnPush to avoid full tree checks on every proof update.

• Proof.timestamp — Cached the converted value on first access via private _timestamp?: number. The threshold conversion was a hot path hit on every sort in large collections.

• CapacitorStoragePreferences.initializeValue() — Wrapped check-and-set in mutex.runExclusive() to close the TOCTOU window where concurrent callers could both pass the subjects.has(key) guard.

• MediaStore._write() — Moved base64ToBlob() outside the mutex. On native platform with large files (10+ MB), blob conversion was holding the lock and blocking concurrent reads.

• DiaBackendAuthService.getToken() — Replaced broken new Promise(resolve => ...) pattern with pure async/await. The original called reject from lodash-es (not the Promise callback), so token-empty errors were silently swallowed. Also removed the now-unused reject lodash import.

  // Before: reject was lodash's array filter, not Promise.reject
  private async getToken() {
    return new Promise<string>(resolve => {
      this.preferences.getString(PrefKeys.TOKEN).then(token => {
        if (token.length !== 0) { resolve(token); }
        else { reject(new Error('...')); } // ← lodash reject, no-op here
      });
    });
  }
  
  // After
  private async getToken() {
    const token = await this.preferences.getString(PrefKeys.TOKEN);
    if (!token) throw new Error('Cannot get DIA backend token which is empty.');
    return token;
  }

• NetworkService — Added reconnected$ observable (using pairwise + filter) that emits on false → true connectivity transitions, enabling consumers to trigger automatic upload recovery.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• download.cypress.io
  • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node index.js --exec install conf�� get --global it-cloneD1iQJU/node_modules/.bin/node core.hooksPath (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)