fix: deep link injection, missing AuthGuard on sensitive routes, and SSRF in ActionsService.send$()#3403
Draft
fix: deep link injection, missing AuthGuard on sensitive routes, and SSRF in ActionsService.send$()#3403
Conversation
Agent-Logs-Url: https://github.com/numbersprotocol/capture-cam/sessions/3475c3c9-2ef8-4645-a87d-8c634aa33cb2 Co-authored-by: numbers-official <181934381+numbers-official@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix deep link handler validation issue
fix: deep link injection, missing AuthGuard on sensitive routes, and SSRF in ActionsService.send$()
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three high-severity security vulnerabilities in the deep link handler, route guards, and Bubble API client.
Deep link injection (
app.component.ts)The previous handler split on
.appand passed the tail directly torouter.navigateByUrl()— no host validation, no parameter stripping, no route allowlist.Changes: strict hostname check (
capture-cam-deep-links.web.app), matrix-parameter stripping per segment, path-traversal guard, and an explicit route allowlist.Missing
AuthGuardon sensitive routes (app-routing.module.ts)Six routes had no
canActivateguard, making them reachable by unauthenticated users — including via crafted deep links:wallets— wallet balances / key materialcontacts— user contact listmedia-viewer/:src— arbitrary user-controlled URL as route paraminvitation,data-policy,terms-of-useAdded
canActivate: [AuthGuard]to all six.SSRF vector in
ActionsService.send$()(actions.service.ts)send$(url, body)accepted an arbitrary URL and issued an unauthenticated POST with no restrictions. Now validates the target starts with a known Bubble API base URL (BUBBLE_DB_URLorBUBBLE_API_URL); any other target throwsError: Request to disallowed URL: <url>.