Skip to content

Commit 3116d5d

Browse files
authored
Merge pull request #90 from numbersprotocol/copilot/fix-missing-rel-attribute
fix: add rel="noopener noreferrer" to all target="_blank" links in modal
2 parents e350410 + 7dfa140 commit 3116d5d

2 files changed

Lines changed: 10 additions & 4 deletions

File tree

src/modal/modal.ts

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -284,6 +284,7 @@ export class CaptureEyeModal extends LitElement {
284284
class="link-text"
285285
href=${this._asset?.showcaseLink ?? '#'}
286286
target="_blank"
287+
rel="noopener noreferrer"
287288
>
288289
${this._asset?.creator ?? ''}
289290
</a>
@@ -367,6 +368,7 @@ export class CaptureEyeModal extends LitElement {
367368
? html`<a
368369
href=${`${Constant.url.profile}/${this.nid}`}
369370
target="_blank"
371+
rel="noopener noreferrer"
370372
>${image}</a
371373
>`
372374
: html`<div class="shimmer-profile-img"></div>`}
@@ -414,6 +416,7 @@ export class CaptureEyeModal extends LitElement {
414416
class="link-text"
415417
href=${this._asset.explorerUrl}
416418
target="_blank"
419+
rel="noopener noreferrer"
417420
>
418421
<span class="value-text">${transactionText}</span>
419422
</a>`
@@ -435,6 +438,7 @@ export class CaptureEyeModal extends LitElement {
435438
class="link-text"
436439
href=${Constant.url.explorer}
437440
target="_blank"
441+
rel="noopener noreferrer"
438442
>
439443
<span class="value-text"
440444
>${Constant.text.numbersMainnet}</span
@@ -474,7 +478,7 @@ export class CaptureEyeModal extends LitElement {
474478
475479
<span class="field-text">${item.field}:</span>
476480
${item.url
477-
? html`<a class="link-text" href=${item.url} target="_blank"
481+
? html`<a class="link-text" href=${item.url} target="_blank" rel="noopener noreferrer"
478482
><span class="value-text">${item.value}</span></a
479483
>`
480484
: html`<span class="value-text">${item.value}</span>`}
@@ -501,12 +505,12 @@ export class CaptureEyeModal extends LitElement {
501505
: Constant.text.viewMore;
502506
return html`
503507
<div class="section">
504-
<a href=${actionButtonLink} target="_blank"
508+
<a href=${actionButtonLink} target="_blank" rel="noopener noreferrer"
505509
><button class="view-more-btn">${actionButtonText}</button></a
506510
>
507511
<div class="powered-by">
508512
${this._assetLoaded
509-
? html`<a href=${Constant.url.numbersWebsite} target="_blank"
513+
? html`<a href=${Constant.url.numbersWebsite} target="_blank" rel="noopener noreferrer"
510514
>Powered by Numbers Protocol</a
511515
>`
512516
: html`<div class="shimmer-text" style="height: auto;">&nbsp;</div>`}
@@ -533,6 +537,7 @@ export class CaptureEyeModal extends LitElement {
533537
<a
534538
href=${this.currentEngagementZone.link}
535539
target="_blank"
540+
rel="noopener noreferrer"
536541
class="eng-link"
537542
@click=${this.trackEngagement}
538543
>

src/test/modal_test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ suite('capture-eye-modal', () => {
6969
</div>
7070
</div>
7171
<div class="section">
72-
<a href="https://asset.captureapp.xyz/" target="_blank"><button class="view-more-btn">View More</button></a>
72+
<a href="https://asset.captureapp.xyz/" target="_blank" rel="noopener noreferrer"><button class="view-more-btn">View More</button></a>
7373
<div class="powered-by">
7474
<div
7575
class="shimmer-text"
@@ -84,6 +84,7 @@ suite('capture-eye-modal', () => {
8484
<a
8585
class="eng-link"
8686
href="https://captureapp.xyz"
87+
rel="noopener noreferrer"
8788
target="_blank"
8889
>
8990
<img

0 commit comments

Comments
 (0)