Skip to content

Security hygiene: gitignore, redact hardcoded secrets, update versions, add rate limiting and WS origin validation #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Security hygiene: gitignore, redact hardcoded secrets, update versions, add rate limiting and WS origin validation #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3286037
Initial plan
Copilot Feb 28, 2026
f6068c7
Fix medium-severity security findings: gitignore, hardcoded data, ver…
Copilot Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,8 @@
.subnet-cli.pk
.env
*.pem
*.key
*.crt
*.log
.DS_Store
node_modules/
8 changes: 4 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ Before validation staking expires, any wallet can not stake to a validator again

Validator version distributions: [mainnet](https://explorer-xp.avax.network/validators), [testnet](https://explorer-xp.avax-test.network/validators)

[Renew Numbers Validators](https://app.asana.com/0/1202305127727547/1202919355642524/f) (internal task)
Renew Numbers Validators (refer to internal task tracker)

## Import Existing L1 in Avalanche CLI

Expand Down Expand Up @@ -395,10 +395,10 @@ It should return something like this.
{
"jsonrpc": "2.0",
"result": {
"nodeID": "NodeID-5mb46qkSBj81k9g9e4VFjGGSbaaSLFRzD",
"nodeID": "NodeID-<your-node-id>",
"nodePOP": {
"publicKey": "0x8f95423f7142d00a48e1014a3de8d28907d420dc33b3052a6dee03a3f2941a393c2351e354704ca66a3fc29870282e15",
"proofOfPossession": "0x86a3ab4c45cfe31cae34c1d06f212434ac71b1be6cfe046c80c162e057614a94a5bc9f1ded1a7029deb0ba4ca7c9b71411e293438691be79c2dbf19d1ca7c3eadb9c756246fc5de5b7b89511c7d7302ae051d9e03d7991138299b5ed6a570a98"
"publicKey": "0x<your-bls-public-key>",
"proofOfPossession": "0x<your-bls-proof-of-possession>"
}
},
"id": 1
Expand Down
6 changes: 3 additions & 3 deletions chains/update-validator-mainnet.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
#!/bin/bash

AVALANCHEGO_PREVIOUS_VERSION="1.10.7"
AVALANCHEGO_VERSION="1.10.11"
SUBNET_EVM_VERSION="0.5.6"
AVALANCHEGO_PREVIOUS_VERSION="1.10.11"
AVALANCHEGO_VERSION="1.14.1"
SUBNET_EVM_VERSION="0.8.0"
# Numbers Mainnet
VM_ID="qeX7kcVMMkVLB9ZJKTpvtSjpLbtYooNEdpFzFShwRTFu76qdx"
SUBNET_ID="2gHgAgyDHQv7jzFg6MxU2yyKq5NZBpwFLFeP8xX2E3gyK1SzSQ"
Expand Down
6 changes: 3 additions & 3 deletions chains/update-validator-testnet.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
#!/bin/bash

AVALANCHEGO_PREVIOUS_VERSION="1.10.7"
AVALANCHEGO_VERSION="1.10.11"
SUBNET_EVM_VERSION="0.5.6"
AVALANCHEGO_PREVIOUS_VERSION="1.10.11"
AVALANCHEGO_VERSION="1.14.1"
SUBNET_EVM_VERSION="0.8.0"
# Numbers Testnet
VM_ID="kmYb53NrmqcW7gfV2FGHBHWXNA6YhhWf7R7LoQeGj9mdDYuaT"
SUBNET_ID="81vK49Udih5qmEzU7opx3Zg9AnB33F2oqUTQKuaoWgCvFUWQe"
Expand Down
3 changes: 3 additions & 0 deletions faucet/default
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ upstream faucet {
server localhost:8000;
}

limit_req_zone $binary_remote_addr zone=faucet_api:10m rate=10r/m;

# Default server configuration
#
server {
Expand Down Expand Up @@ -125,6 +127,7 @@ server {
}

location /api/ {
limit_req zone=faucet_api burst=5 nodelay;
proxy_pass http://faucet;
}

Expand Down
8 changes: 8 additions & 0 deletions rpc/testnet/etc/nginx/sites-available/default
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@ upstream validator {
server <internal-ip-val-t5>:9650;
}

map $http_origin $allowed_ws_origin {
default "";
"~^https://(testnetrpc\.num\.network|testnetrpc\.numbersprotocol\.io)$" $http_origin;
}

# Default server configuration
#
server {
Expand Down Expand Up @@ -137,6 +142,9 @@ server {
proxy_set_header Upgrade $http_upgrade;
proxy_set_header Connection "Upgrade";
proxy_set_header Host $host;
proxy_set_header Origin $allowed_ws_origin;
proxy_read_timeout 3600s;
proxy_send_timeout 3600s;
}

# pass PHP scripts to FastCGI server
Expand Down