Refactor: Improve robustness and clarity of grant management scripts#101
Open
loigaak wants to merge 1 commit into
Open
Refactor: Improve robustness and clarity of grant management scripts#101loigaak wants to merge 1 commit into
loigaak wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces several improvements to the grant management scripts:
scripts/sdg_utils.py: Enhances theparse_issuefunction to prevent a potentialAttributeErrorif the 'Amount requested' field is missing from an issue body. It also improves efficiency by using a set for label lookups.scripts/allocate_funds.py: Corrects the default type for the--funding_limitargument from a string to an integer, aligning with itstype=intspecification.scripts/project_selection.py: Refactors theselect_proposals_to_fundfunction by removing the redundanttemp_budget_remainingvariable, improving code clarity and maintainability without altering the existing budget allocation logic.These changes improve the overall robustness and readability of the grant processing tools.
Fixes #31 (by improving the underlying system that processes grant proposals like the one described in #31)