Fix: Robustness and consistency in SDG scripts#102
Open
loigaak wants to merge 1 commit into
Open
Conversation
- Handle missing 'Amount requested' field gracefully in `parse_issue` to prevent `AttributeError`. - Standardize GitHub Token environment variable usage to `GITHUB_TOKEN` across `sdg_utils.py` for consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25
This PR addresses two issues in the Small Development Grant (SDG) processing scripts:
parse_issuefor 'Amount requested': Previously, if an issue body did not contain the 'Amount requested' field in the expected format, theparse_issuefunction would raise anAttributeErrorwhen trying to accessamount_match.group(2)on aNoneobject. This has been fixed by initializingamount_requestedto 0 and checking ifamount_matchis notNonebefore attempting to extract the value.GH_TOKENandGITHUB_TOKENenvironment variables for GitHub API authentication. Theupdate_boardfunction now usesGITHUB_TOKENfor consistency with other parts of the codebase, ensuring that a single environment variable is sufficient for all GitHub API interactions.