Added winbox icons#5742
Closed
cuzrawr wants to merge 3 commits intonumixproject:masterfrom
Closed
Conversation
changed title
changed title
|
How come the circle icon seems to have a smaller "greener" circle inside? shouldn't it be all 1 color? |
palob
requested changes
Jul 14, 2021
Member
palob
left a comment
There was a problem hiding this comment.
Hi, thank you for your contribution.
Your icons contain encapsulated raster graphics. This defies the purpose of vector (SVG) icons, the icons won't scale up this way.
What is more, when I open the files in Inkscape I just see white circle on top of the baseplate.
Contributor
Member
|
From distance the symbol looks a bit big. It should fit inside a 30px X 30px circle (like the one in the template files). The crescent shapes should be composed by means of a path difference of 2 circles and need to be aligned to the pixel grid. |
Member
|
Closing in favour of #5777. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #5740
That app running under wine and need some hardcore fixes, cause most .desktop files are have
or just:
Also, replacing

/usr/share/pixmaps/winbox.pngworks. My dockbar app called "plank" shows new icon properly (here how it looks like):But xfce4-panel looks like this (tried many different combinations with png\svg replacement but seems wine didn't eat ico properly and shows hardcoded into .exe):

btw that are not big problem at all, because in my dock now everything is in harmony with square icons. :-)