Skip to content

Added winbox icon#5777

Open
ingria wants to merge 1 commit into
numixproject:masterfrom
ingria:winbox
Open

Added winbox icon#5777
ingria wants to merge 1 commit into
numixproject:masterfrom
ingria:winbox

Conversation

@ingria

@ingria ingria commented Feb 21, 2022

Copy link
Copy Markdown
Contributor

Fixed crescent shapes and fitted them into 30px circle.

Original icon Circle icon Square icon

See also #5742, fixes #5740.

source svg

winbox

@ingria ingria changed the title Added winbox icon (fixes #5740) Added winbox icon Feb 21, 2022
@ingria

ingria commented Feb 21, 2022

Copy link
Copy Markdown
Contributor Author

Just found this unofficial snap: https://snapcraft.io/winbox

Is it possible to support it too? Its .desktop file is here.

@palob palob added the merge label Feb 21, 2022
@ingria ingria force-pushed the winbox branch 2 times, most recently from 88ee37c to 95eae48 Compare February 21, 2022 14:51
@palob

palob commented Feb 21, 2022

Copy link
Copy Markdown
Member

No, as soon as there is a / in the Icon= line this means the icon path is hardcoded and you need to edit the .desktop file.

I know it's from the original PR but I don't think the .exe symlinks in data.json will work. They should be removed.

@ingria ingria force-pushed the winbox branch 2 times, most recently from 4a31b73 to 74f948f Compare February 21, 2022 20:42
@palob

palob commented Feb 26, 2022

Copy link
Copy Markdown
Member

Thank you for the PRs. There symbol should be smaller still (and moved up/to the right maybe) so that it fits into a centered 30x30 circle.

circcle

@mrmeszaros

mrmeszaros commented Sep 22, 2022

Copy link
Copy Markdown
Contributor

The drop shadow seems off to me.
For the circle it is usually offset to the bottom right (1, 1).
For the square it is offset to the bottom (0, 1).

Also, just a heads up, You don't have to amend the commit and force-push - all commits on the branch are rebased and squashed into one when merging.

@palob

palob commented Dec 15, 2022

Copy link
Copy Markdown
Member

Additional icon name com.mikrotik.Winbox required.

@palob palob mentioned this pull request Feb 18, 2023

@Foggalong Foggalong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am no longer a member of Numix Project so my review is moot (see #5868).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

Icon Request: winbox

4 participants