adding default switch branch + newline EOF in test

Author: SwayamInSync

src/csrc/umath/matmul.cpp

@@ -173,6 +173,11 @@ quad_matmul_strided_loop_aligned(PyArrayMethod_Context *context, char *const dat
                                     &beta, C_ptr, ldc_numpy);
                 break;
             }
+
+            default:
+                PyErr_SetString(PyExc_RuntimeError,
+                                "internal error: unknown MatmulOperationType");
+                return -1;
         }
 
         if (result != 0) {
@@ -235,6 +240,10 @@ quad_matmul_strided_loop_unaligned(PyArrayMethod_Context *context, char *const d
             temp_B_buffer = new Sleef_quad[n * p];
             temp_C_buffer = new Sleef_quad[m * p];
             break;
+        default:
+            PyErr_SetString(PyExc_RuntimeError,
+                            "internal error: unknown MatmulOperationType");
+            return -1;
     }
 
     int result = 0;
@@ -276,6 +285,12 @@ quad_matmul_strided_loop_unaligned(PyArrayMethod_Context *context, char *const d
                 }
                 break;
             }
+
+            default:
+                PyErr_SetString(PyExc_RuntimeError,
+                                "internal error: unknown MatmulOperationType");
+                result = -1;
+                break;
         }
 
         if (result != 0) {
@@ -288,7 +303,9 @@ quad_matmul_strided_loop_unaligned(PyArrayMethod_Context *context, char *const d
     delete[] temp_C_buffer;  // delete[] on nullptr is a no-op
 
     if (result != 0) {
-        PyErr_SetString(PyExc_RuntimeError, "QBLAS operation failed");
+        if (!PyErr_Occurred()) {
+            PyErr_SetString(PyExc_RuntimeError, "QBLAS operation failed");
+        }
         return -1;
     }
 

tests/test_dot.py

@@ -1053,4 +1053,4 @@ def test_batched_larger(self, batch, m, k, n):
         A_f = rng.standard_normal((batch, m, k))
         B_f = rng.standard_normal((batch, k, n))
         _assert_matmul_matches_float64(_qnd(A_f), _qnd(B_f), A_f, B_f,
-                                       rtol=1e-13, atol=1e-13)
+                                       rtol=1e-13, atol=1e-13)