applying other reviews

Author: SwayamInSync

src/csrc/scalar.c

@@ -329,21 +329,6 @@ QuadPrecision_str_dragon4(QuadPrecisionObject *self)
     }
 }
 
-static PyObject *
-QuadPrecision_str(QuadPrecisionObject *self)
-// This is just define here for debugging, we actually use QuadPrecision_str_dragon4 for __str__ method.
-{
-    char buffer[128];
-    if (self->backend == BACKEND_SLEEF) {
-        Sleef_snprintf(buffer, sizeof(buffer), "%.*Qe", SLEEF_QUAD_DIG, self->value.sleef_value);
-    }
-    else {
-        snprintf(buffer, sizeof(buffer), "%.*Le", LDBL_DECIMAL_DIG - 1,
-                 self->value.longdouble_value);
-    }
-    return PyUnicode_FromString(buffer);
-}
-
 static PyObject *
 QuadPrecision_repr_dragon4(QuadPrecisionObject *self)
 {

tests/test_quaddtype.py

@@ -5379,7 +5379,6 @@ class TestScalarPickle:
 
     @pytest.mark.parametrize("backend", ["sleef", "longdouble"])
     def test_pickle_scalar_issue_repro(self, backend):
-        """The exact repro from #99: was RuntimeError on loads()."""
         import pickle
         original = QuadPrecision("123.456", backend=backend)
         loaded = pickle.loads(pickle.dumps(original))
@@ -5402,9 +5401,7 @@ def test_pickle_scalar_finite_roundtrip(self, backend, value):
         loaded = pickle.loads(pickle.dumps(original))
         assert isinstance(loaded, QuadPrecision)
         assert loaded.dtype == QuadPrecDType(backend=backend)
-        # Exact equality: pickle/unpickle should not lose any bits.
         assert loaded == original
-        # And the canonical repr should match.
         assert str(loaded) == str(original)
 
     @pytest.mark.parametrize("backend", ["sleef", "longdouble"])
@@ -5414,7 +5411,7 @@ def test_pickle_scalar_inf(self, backend):
             original = QuadPrecision(s, backend=backend)
             loaded = pickle.loads(pickle.dumps(original))
             assert isinstance(loaded, QuadPrecision)
-            assert loaded == original  # inf == inf, -inf == -inf
+            assert loaded == original
             assert float(loaded) == float(original)
 
     @pytest.mark.parametrize("backend", ["sleef", "longdouble"])
@@ -5423,7 +5420,6 @@ def test_pickle_scalar_nan(self, backend):
         original = QuadPrecision("nan", backend=backend)
         loaded = pickle.loads(pickle.dumps(original))
         assert isinstance(loaded, QuadPrecision)
-        # NaN != NaN, so we check isnan instead.
         import math
         assert math.isnan(float(loaded))
         assert loaded.dtype == QuadPrecDType(backend=backend)
@@ -5447,13 +5443,9 @@ def test_pickle_scalar_preserves_type(self):
 
     @pytest.mark.parametrize("backend", ["sleef", "longdouble"])
     def test_pickle_scalar_preserves_full_precision(self, backend):
-        """Diagnostic precision-loss test. Two values with the same printed
-        repr can still differ at the full bit width, so check via subtraction
-        (which preserves precision) — `loaded - original` must be exactly zero.
-        Catches the regression where the longdouble path went through (double)."""
+        """Compare via subtraction, not repr: two values with the same printed
+        repr can still differ at the full bit width."""
         import pickle
-        # A value with more than 16 significant digits — exercises precision
-        # beyond what double can represent.
         original = QuadPrecision("3.14159265358979323846264338327950288",
                                  backend=backend)
         loaded = pickle.loads(pickle.dumps(original))
@@ -5487,16 +5479,6 @@ def test_pickle_scalar_in_list(self):
         assert math.isnan(float(loaded[2]))
         assert loaded[3] == original[3]
 
-    @pytest.mark.parametrize("backend", ["sleef", "longdouble"])
-    def test_pickle_scalar_loads_does_not_raise(self, backend):
-        """Direct regression on the exact failure mode in the bug report
-        (RuntimeError from numpy's legacy SETITEM path)."""
-        import pickle
-        try:
-            pickle.loads(pickle.dumps(QuadPrecision("123.456", backend=backend)))
-        except RuntimeError as exc:
-            pytest.fail(f"pickle.loads raised RuntimeError: {exc}")
-
 
 @pytest.mark.parametrize("dtype", [
     "bool",