Merged
Conversation
danielballan
approved these changes
Sep 30, 2025
rossbar
approved these changes
Sep 30, 2025
Collaborator
rossbar
left a comment
rossbar
left a comment
There was a problem hiding this comment.
Thanks @bsipocz , +1 for these updates! I wasn't quite sure how to make the appropriate tox changes.
Re: min dependencies, I agree - according to the spec0 schedule we could be more aggressive about dropping older versions, but I agree with the general take that there is no real harm in keeping that lower bound wider for the tutorials. We certainly expect things to work with "older" versions.
The one thing I'd be wary of is running into old versions for which there are no longer publicly-hosted wheels. This could add a ton of (IMO unnecessary) burden on CI as things are built from the source tarballs.
Member
Author
|
yeap, certainly we shouldn't have oldest versions tha don't have wheels! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dropping support/testing for oldest versions could be more drastic, but OTOH there is nothing in the notebooks that should not work with older versions so I kept them still very old.
I expect tests to pass with python 3.13 and 3.14, but I suppose we'll have to see what CI says.