to_quad + sign tests

Author: SwayamInSync

quaddtype/numpy_quaddtype/src/casts.cpp

@@ -950,11 +950,21 @@ inline quad_value
 to_quad<spec_npy_half>(npy_half x, QuadBackendType backend)
 {
     quad_value result;
+    double d = npy_half_to_double(x);
     if (backend == BACKEND_SLEEF) {
-        result.sleef_value = Sleef_cast_from_doubleq1(npy_half_to_double(x));
+        if (std::isnan(d)) {
+            result.sleef_value = std::signbit(d) ? QUAD_PRECISION_NEG_NAN : QUAD_PRECISION_NAN;
+        }
+        else if (std::isinf(d)) {
+            result.sleef_value = (d > 0) ? QUAD_PRECISION_INF : QUAD_PRECISION_NINF;
+        }
+        else {
+            Sleef_quad temp = Sleef_cast_from_doubleq1(d);
+            std::memcpy(&result.sleef_value, &temp, sizeof(Sleef_quad));
+        }
     }
     else {
-        result.longdouble_value = (long double)npy_half_to_double(x);
+        result.longdouble_value = (long double)d;
     }
     return result;
 }
@@ -964,8 +974,18 @@ inline quad_value
 to_quad<float>(float x, QuadBackendType backend)
 {
     quad_value result;
-    if (backend == BACKEND_SLEEF) {
-        result.sleef_value = Sleef_cast_from_doubleq1(x);
+    if (backend == BACKEND_SLEEF) 
+    {
+      if (std::isnan(x)) {
+          result.sleef_value = std::signbit(x) ? QUAD_PRECISION_NEG_NAN : QUAD_PRECISION_NAN;
+      }
+      else if (std::isinf(x)) {
+          result.sleef_value = (x > 0) ? QUAD_PRECISION_INF : QUAD_PRECISION_NINF;
+      }
+      else {
+          Sleef_quad temp = Sleef_cast_from_doubleq1(static_cast<double>(x));
+          std::memcpy(&result.sleef_value, &temp, sizeof(Sleef_quad));
+      }
     }
     else {
         result.longdouble_value = (long double)x;
@@ -978,8 +998,18 @@ inline quad_value
 to_quad<double>(double x, QuadBackendType backend)
 {
     quad_value result;
-    if (backend == BACKEND_SLEEF) {
-        result.sleef_value = Sleef_cast_from_doubleq1(x);
+    if (backend == BACKEND_SLEEF) 
+    {
+      if (std::isnan(x)) {
+          result.sleef_value = std::signbit(x) ? QUAD_PRECISION_NEG_NAN : QUAD_PRECISION_NAN;
+      }
+      else if (std::isinf(x)) {
+          result.sleef_value = (x > 0) ? QUAD_PRECISION_INF : QUAD_PRECISION_NINF;
+      }
+      else {
+          Sleef_quad temp = Sleef_cast_from_doubleq1(x);
+          std::memcpy(&result.sleef_value, &temp, sizeof(Sleef_quad));
+      }
     }
     else {
         result.longdouble_value = (long double)x;
@@ -992,8 +1022,18 @@ inline quad_value
 to_quad<long double>(long double x, QuadBackendType backend)
 {
     quad_value result;
-    if (backend == BACKEND_SLEEF) {
-        result.sleef_value = Sleef_cast_from_doubleq1(x);
+    if (backend == BACKEND_SLEEF) 
+    {
+      if (std::isnan(x)) {
+          result.sleef_value = std::signbit(x) ? QUAD_PRECISION_NEG_NAN : QUAD_PRECISION_NAN;
+      }
+      else if (std::isinf(x)) {
+          result.sleef_value = (x > 0) ? QUAD_PRECISION_INF : QUAD_PRECISION_NINF;
+      }
+      else {
+          Sleef_quad temp = Sleef_cast_from_doubleq1(static_cast<double>(x));
+          std::memcpy(&result.sleef_value, &temp, sizeof(Sleef_quad));
+      }
     }
     else {
         result.longdouble_value = x;

quaddtype/tests/test_quaddtype.py

@@ -5397,4 +5397,18 @@ def test_quad_to_quad_backend_casting(src_backend, dst_backend, value):
     elif src_backend != dst_backend:  
       np.testing.assert_allclose(dst_arr, res_arr, rtol=1e-15)
     else:
-      np.testing.assert_array_equal(dst_arr, res_arr)
+      np.testing.assert_array_equal(dst_arr, res_arr)
+
+# quad -> float will be tested in same_values tests
+@pytest.mark.parametrize("dtype", [np.float16, np.float32, np.float64, np.longdouble])
+@pytest.mark.parametrize("val", [0.0, -0.0, float('inf'), float('-inf'), float('nan'), float("-nan")])
+def test_float_to_quad_sign_preserve(dtype, val):
+    """Test that special floating-point values roundtrip correctly."""
+    src = np.array([val], dtype=dtype)
+    result = src.astype(QuadPrecDType())
+
+    assert np.signbit(result) == np.signbit(val), f"Sign bit failed for {dtype} with value {val}"
+    if np.isnan(val):
+        assert np.isnan(result), f"NaN failed for {dtype}"
+    else:
+        assert result == val, f"{val} failed for {dtype}"