Make object_qsort generic in arrsize type#207
Merged
Conversation
added 2 commits
May 20, 2025 11:59
- Change arrsize parameter and all related indexing/size variables in object_qsort to use a template parameter ArrSize instead of fixed-size types. - Add static_asserts to ensure ArrSize and key_func return type are either 32-bit or 64-bit. - Change the type of the arg vector from uint32_t to ArrSize for consistency and correctness.
Closed
sterrettm2
reviewed
May 30, 2025
sterrettm2
left a comment
sterrettm2
left a comment
Contributor
There was a problem hiding this comment.
Looks good overall; my only comment is that I don't think the name U is good for the type used for indices, especially as it shows up in the public-facing API. I think it should probably have a more relevant name. Besides that, this looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for 32-bit and 64-bit integer types for
arrsize: Updated theobject_qsortfunction to acceptarrsizeas any 32-bit or 64-bit integer type by introducing a new template parameterU. Updated README to reflect these changes.Fixes #206