Added new functionality to match with files in cwd#1096
Open
Avyukt27 wants to merge 1 commit into
Open
Conversation
Contributor
|
I'm not convinced that this is a good idea. CwdAwareHinter is about the history, not the file system. |
Author
|
Should I move this to another hinter type then? |
Contributor
|
Correct me if I'm wrong. I think fish adds completion results as hints and has a smart sorting algorithm so that the hints change between historical commands and completions as you type. Basically hints for files of CWD would be a small subset of such functionality. Probably better to make it more general IMHO. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated
CwdAwareHinterto add a hinting from cwdIf the history searching does not provide any auto-suggestion, the hinter will search through the cwd for matches instead of returning nothing.
Related Issues
Fixes nushell/nushell#5799