feat: finally clause in ctrl_try (#243)

New finally keyword introduced in nu v0.111.0

Author: blindFS

.github/workflows/ci.yml

@@ -34,6 +34,8 @@ jobs:
         uses: actions/checkout@v4
       - name: Set up tree-sitter
         uses: tree-sitter/setup-action/cli@v2
+        with:
+          tree-sitter-ref: v0.25.10
       - name: Set up examples
         shell: bash
         run: |-

grammar.js

@@ -1586,6 +1586,10 @@ function _ctrl_try_rule(parenthesized) {
       keyword().catch,
       field('catch_branch', $._blosure),
     ];
+    const seq_finally_array = [
+      keyword().finally,
+      field('finally_branch', $._blosure),
+    ];
     const seq_array = [
       keyword().try,
       field('try_branch', $.block),
@@ -1594,6 +1598,11 @@ function _ctrl_try_rule(parenthesized) {
           _insert_newline($, seq_catch_array, true, false) :
           seq(...seq_catch_array),
       ),
+      optional(
+        parenthesized ?
+          _insert_newline($, seq_finally_array, true, false) :
+          seq(...seq_finally_array),
+      ),
     ];
     return parenthesized ?
       _insert_newline($, seq_array, false, false) :
@@ -1956,6 +1965,7 @@ function keyword() {
     else: 'else',
     try: 'try',
     catch: 'catch',
+    finally: 'finally',
     match: 'match',
 
     in: 'in',

queries/nu/highlights.scm

@@ -22,6 +22,7 @@
 [
   "try"
   "catch"
+  "finally"
   "error"
 ] @keyword.exception
 

script/known-failures.txt

@@ -21,6 +21,7 @@ examples/nu_scripts/custom-completions/pytest/pytest-completions.nu
 examples/nu_scripts/custom-menus/current_session_history_menu.nu
 examples/nu_scripts/example-config/init.nu
 examples/nu_scripts/make_release/gen-ts-ext.nu
+examples/nu_scripts/make_release/notes/notice.nu
 examples/nu_scripts/make_release/notes/tools.nu
 examples/nu_scripts/modules/duplicates/example.nu
 examples/nu_scripts/modules/kubernetes/complete.nu