fix for comment in interpolated string#252
Open
fdncred wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
ugh, apparently this fix breaks other things. i'll look a bit more before giving up. :) |
Contributor
|
Should be much easier if there's this feature of ts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #251 by updating the
commentregex to:to
meaning comments start with
#and stop at),], and}. The trade-off is that),], and}can no longer appear in comments on the same line as#.It's probably an acceptable trade-off.
The problem was strings like
$"foo (## some comment) bar"weren't being interpreted correctly and the tree-sitter parser was basically breaking and didn't know what to do.tree-sitter testwould work better for me.ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSIONto true in the CI to get this to work since there's no new action that uses Node 24 yet.