Display relevant weeks on exam timetable#4418
Open
not-a-scam wants to merge 9 commits into
Open
Conversation
Contributor
|
PR author is not in the allowed authors list. |
|
@not-a-scam is attempting to deploy a commit to the modsbot's projects Team on Vercel. A member of the Team first needs to authorize it. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4418 +/- ##
==========================================
+ Coverage 54.52% 56.44% +1.91%
==========================================
Files 274 317 +43
Lines 6076 6963 +887
Branches 1455 1683 +228
==========================================
+ Hits 3313 3930 +617
- Misses 2763 3033 +270 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Initially just created to close #1717
Additionally updated exam timetable to only display the week when exams to be taken are happening. Previously, the first week will always be displayed even if there are no exams to be taken.

Implementation
Full Week Display
Display relevant weeks
Other Information
First PR here! Feedback is appreciated!
Created it so that if there are no exams, the getExamCalendar would return the current date as the first date instead for simplicity, but not sure if there are better return value? Considered using the first day of exams from the academic calendar but I thought the additional call would be unnecessary since the value isn't used.
I think the addition of Sunday looks fine on mobile. Seemed to be a concern in Exams on Saturday should show full week #1717 but included a gif for reference