Skip to content

Commit 7edca51

Browse files
Update reports.proto (#2678)
* Update `reports.proto` * update generated proto * avoid branch prefix * fix rector config * fix PHPStan --------- Co-authored-by: spawnia <spawnia@users.noreply.github.com> Co-authored-by: Benedikt Franke <benedikt.franke@mll.com>
1 parent 661f394 commit 7edca51

6 files changed

Lines changed: 46 additions & 11 deletions

File tree

.github/workflows/update-reports-proto.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,5 +24,5 @@ jobs:
2424
with:
2525
title: Update `reports.proto`
2626
commit-message: Update `reports.proto`
27-
branch: patch/update-reports-proto
27+
branch: update-reports-proto
2828
delete-branch: true

rector.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@
4747
Rector\PHPUnit\CodeQuality\Rector\Class_\NarrowUnusedSetUpDefinedPropertyRector::class, // falsely removes $this->schema assignments in some tests
4848
Rector\PHPUnit\PHPUnit100\Rector\StmtsAwareInterface\WithConsecutiveRector::class, // messes up our custom withConsecutive replacement
4949
Rector\PHPUnit\PHPUnit60\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector::class, // does not recognize mockResolver
50-
Rector\PHPUnit\CodeQuality\Rector\MethodCall\AssertCountWithZeroToAssertEmptyRector::class, // Allows garbage
5150
Rector\PHPUnit\CodeQuality\Rector\MethodCall\AssertEmptyNullableObjectToAssertInstanceofRector::class, // Makes assertions more brittle
5251
]);
5352
$rectorConfig->paths([

src/Schema/Directives/HideDirective.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public function __construct()
2626
assert($app instanceof Application);
2727

2828
$environment = $app->environment();
29-
assert(is_string($environment), 'Calling this method without parameters returns the current value of the environment.');
29+
assert(is_string($environment), 'Calling this method without parameters returns the current value of the environment.'); // @phpstan-ignore function.alreadyNarrowedType,function.alreadyNarrowedType (dynamic type known only with the latest Larastan version)
3030

3131
$this->env = $environment;
3232
}
35 Bytes
Binary file not shown.

src/Tracing/FederatedTracing/Proto/QueryMetadata.php

Lines changed: 42 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Tracing/FederatedTracing/reports.proto

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -589,6 +589,8 @@ message QueryMetadata {
589589
string signature = 2;
590590
// (Optional) Persisted query ID that was used to request this operation.
591591
string pq_id = 3;
592+
// The query id. Must be present for all operations. If missing, operations will appear in the insights page without a signature and possibly without a name.
593+
string operation_id = 4;
592594
}
593595

594596
message ExtendedReferences {

0 commit comments

Comments
 (0)