Skip to content

Commit ac06e5f

Browse files
Update reports.proto (#2683)
1 parent 5a80dd2 commit ac06e5f

7 files changed

Lines changed: 82 additions & 38 deletions

File tree

src/Console/FieldCommand.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ protected function getDefaultNamespace($rootNamespace): string
3737
protected function nameParts(): array
3838
{
3939
$name = $this->argument('name');
40-
if (! is_string($name)) {
40+
if (! is_string($name)) { // @phpstan-ignore function.alreadyNarrowedType (necessary in some dependency versions)
4141
throw new \InvalidArgumentException('You must specify the name for the class to generate.');
4242
}
4343

src/Console/LighthouseGeneratorCommand.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ abstract class LighthouseGeneratorCommand extends GeneratorCommand
1616
protected function getNameInput(): string
1717
{
1818
$name = $this->argument('name');
19-
if (! is_string($name)) {
19+
if (! is_string($name)) { // @phpstan-ignore function.alreadyNarrowedType (necessary in some dependency versions)
2020
throw new \InvalidArgumentException('You must specify the name for the class to generate.');
2121
}
2222

48 Bytes
Binary file not shown.

src/Tracing/FederatedTracing/Proto/QueryMetadata.php

Lines changed: 0 additions & 34 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Tracing/FederatedTracing/Proto/Report.php

Lines changed: 38 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Tracing/FederatedTracing/Proto/ReportHeader.php

Lines changed: 34 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Tracing/FederatedTracing/reports.proto

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -345,6 +345,9 @@ message ReportHeader {
345345
// attached to a schema in the backend.
346346
string executable_schema_id = 11;
347347

348+
// The unique reporting agent that generated this report.
349+
string agent_id = 13;
350+
348351
reserved 3; // removed string service = 3;
349352
}
350353

@@ -556,6 +559,10 @@ message Report {
556559
// input type and enum value references. We need this flag so we can tell if the option is enabled even when there are
557560
// no extended references to report.
558561
bool extended_references_enabled = 9;
562+
563+
// A list of features enabled by router at the time this report was generated.
564+
// It is expected to be included only by Apollo Router, not by any other reporting agent.
565+
repeated string router_features_enabled = 10;
559566
}
560567

561568

@@ -589,8 +596,7 @@ message QueryMetadata {
589596
string signature = 2;
590597
// (Optional) Persisted query ID that was used to request this operation.
591598
string pq_id = 3;
592-
// The query id. Must be present for all operations. If missing, operations will appear in the insights page without a signature and possibly without a name.
593-
string operation_id = 4;
599+
594600
}
595601

596602
message ExtendedReferences {

0 commit comments

Comments
 (0)