feat: add configurable option to customize or disable studio keyboard shortcut#453
Open
mateusznarowski wants to merge 1 commit into
Open
Conversation
Contributor
|
@mateusznarowski is attempting to deploy a commit to the Nuxt Team on Vercel. A member of the Team first needs to authorize it. |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked Issue
Closes #131
📋 Description
Adds a new
shortcutmodule option that allows users to customize or disable the keyboard shortcut used to open Studio.The original implementation only checked
event.metaKey, which maps to the Windows/Super key on Windows/Linux (not Ctrl), making the shortcut non-functional on those platforms. On Windows,Win + .is additionally intercepted by the OS to open the emoji picker, so the event never reached the browser.Changes
shortcutoption inModuleOptions(string | false, default:'meta_.')'meta_.'(default) —Cmd + .on macOS,Ctrl + .on Windows/Linux'shift_meta_k') — parsed using the same format asdefineShortcutsfalse— disables the shortcut entirelymeta/command,ctrl,shift,alt/option) with automaticmeta→Ctrlconversion on Windows/Linux, matchingdefineShortcutsbehaviorapp.vuepassesshortcutvalue todefineShortcutsinstead of hardcoding'meta_.'event.metaKey, which maps to the Windows/Super key on non-macOS platforms, making the shortcut non-functionalFiles changed
src/module/src/module.ts—shortcutoption inModuleOptions, defaults, and runtime configsrc/module/src/runtime/utils/activation.ts— shortcut parsing for unauthenticated userssrc/module/src/runtime/host.ts— passshortcutto Studio app viaStudioHost.metasrc/app/src/types/index.ts—shortcutproperty onStudioHost.metasrc/app/src/app.vue— dynamicdefineShortcutsregistrationUsage