Skip to content

fix(compactRoutes): key NuxtPage by interpolated pattern, not full path #4014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Togetic wants to merge 1 commit into from
+6 −1
Closed

fix(compactRoutes): key NuxtPage by interpolated pattern, not full path #4014

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/runtime/plugins/route-locale-detect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,12 @@ export default defineNuxtPlugin({
const router = useRouter()
for (const route of router.getRoutes()) {
if (route.meta?.__i18nCompact && route.meta.key == null) {
route.meta.key = (r: { path: string }) => r.path
// Key by the record's own interpolated pattern (mirrors Nuxt's default `<NuxtPage>`
// keying) instead of the full resolved path, so nested parent pages stay mounted
// across child navigation and only remount when the locale param actually changes.
const pattern = route.path.replace(/(:\w+)\([^)]+\)/g, '$1').replace(/(:\w+)[?+*]/g, '$1')
route.meta.key = (r: { params: Record<string, string | string[]> }) =>
pattern.replace(/:\w+/g, m => r.params[m.slice(1)]?.toString() || '')
}
}
}
Expand Down
Loading