Skip to content

Apply fix from 6.14 (main) to 6.12.2 to bypass regression#981

Closed
mrleblanc101 wants to merge 3 commits into
nuxt-modules:mainfrom
mrleblanc101:patch-1
Closed

Apply fix from 6.14 (main) to 6.12.2 to bypass regression#981
mrleblanc101 wants to merge 3 commits into
nuxt-modules:mainfrom
mrleblanc101:patch-1

Conversation

@mrleblanc101
Copy link
Copy Markdown

🔗 Linked issue

From our chat

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Currently, the path for spa-loading-template.html is resolve incorrectly in Nuxt 4 with the latest release (6.12.2).
But I cannot use the nightly (main), because there is a regression where class inside pages of a layer are not generated.

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 14, 2025

Deploy Preview for nuxt-tailwindcss ready!

Name Link
🔨 Latest commit d5d733d
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-tailwindcss/deploys/67fe7b2f08716b00089e3ebd
😎 Deploy Preview https://deploy-preview-981--nuxt-tailwindcss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@what-the-diff
Copy link
Copy Markdown

what-the-diff Bot commented Apr 14, 2025

PR Summary

  • Update to Project Configuration File
    The package.json file, which is essentially the heart of any javascript project, has been updated. A new script titled "prepare" has been added. This script, when run, carries out two tasks: pnpm dev:prepare to set up the development environment, and pnpm run build to compile the source code into a deployable state.

  • Adjustments to Source Code Loading Logic
    In the src/internal-context/load.ts file, which dictates how certain parts of the source code are loaded, there's been a switch in function usage. Previously using withSrcDir, the code under the spaLoadingTemplate condition now uses the r function. This changes the way the software locates and loads specific pieces of the codebase during operation.

@mrleblanc101 mrleblanc101 changed the title Apply fix on 6.14 (main) to 6.12.2 to bypass regression Apply fix from 6.14 (main) to 6.12.2 to bypass regression Apr 15, 2025
@ineshbose
Copy link
Copy Markdown
Collaborator

Is this not in nightly? 3f59d4a

@mrleblanc101
Copy link
Copy Markdown
Author

mrleblanc101 commented Apr 15, 2025

Yes, but pages/ in layer don't work in nightly. Not sure why the diff is like that. My branch is behind main. I tried to fix the problem with pages but couldn't figure it out, main has a lot of changes

@ineshbose
Copy link
Copy Markdown
Collaborator

Yeah - I am going to raise a fix for the pages/ soon (unless you beat me to it which would be amazing!)

@mrleblanc101
Copy link
Copy Markdown
Author

@ineshbose
Maybe I'll give it another go, but I couldn't figure it out.
6.13.2 and main are pretty different, there is a significant refactor that makes it harder for me to understand what caused the regression.

@ineshbose
Copy link
Copy Markdown
Collaborator

6.13.2 and main are pretty different, there is a significant refactor that makes it harder for me to understand what caused the regression.

main is 6.13.2 with next set of fixes/features for next release (6.4.0)

@mrleblanc101
Copy link
Copy Markdown
Author

My best guess is adding if (moduleOptions.experimental?.strictScanContentPaths) { around this hook nuxt.hook('pages:extend', async (pages) => { caused the regression in this commit 75efd5c.

But honestly I don't understand much, and I don't know why the change was made 😅

@ineshbose
Copy link
Copy Markdown
Collaborator

closing as we've discussed it is resolved in nightly now

@ineshbose ineshbose closed this Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants