Skip to content

fix: only show Tailwind v4 warning when v4 is used#984

Merged
ineshbose merged 1 commit into
nuxt-modules:mainfrom
cjpearson:issue-983
Apr 25, 2025
Merged

fix: only show Tailwind v4 warning when v4 is used#984
ineshbose merged 1 commit into
nuxt-modules:mainfrom
cjpearson:issue-983

Conversation

@cjpearson
Copy link
Copy Markdown
Contributor

🔗 Linked issue

#983

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Check isTailwind4 before logging the warning so it won't be shown when using v3.

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 25, 2025

👷 Deploy request for nuxt-tailwindcss pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 365133b

@what-the-diff
Copy link
Copy Markdown

what-the-diff Bot commented Apr 25, 2025

PR Summary

  • Enhanced Warning Condition for Tailwind CSS
    The logic behind issuing warnings for Tailwind CSS has been improved. The updated condition now checks if Tailwind CSS version 4 is in use prior to issuing any warning. This enhancement provides more accuracy and relevancy in warnings, thereby improving the user experience.

Copy link
Copy Markdown
Collaborator

@ineshbose ineshbose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're an absolute angel. Part of having nightly-version users is to detect my silly mistakes here and there and help contribute for a stable release. Thank you for using nightly and report this ❤️

@ineshbose ineshbose merged commit 680246d into nuxt-modules:main Apr 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants