fix(config): inline config for useRuntimeConfig() composable#1737
fix(config): inline config for useRuntimeConfig() composable#1737danielroe wants to merge 3 commits into
Conversation
commit: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughFor non-development test builds, the Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/module.ts`:
- Around line 49-54: Update the second replace call in template.getContents to
use a replacer function that returns the injected inlineAppConfig expression,
preventing $ sequences in the configuration from being interpreted as
replacement patterns. Leave the import-removal replacement unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b7fa15ba-fc67-4092-b7c2-0ce2e551ed32
📒 Files selected for processing (2)
examples/app-vitest-full/tests/paths.spec.tssrc/module.ts
🔗 Linked issue
📚 Description
spotted this in elk-zone/elk#3681 -
useRuntimeConfig()currently throws if we don't setwindowproperties, but I think we can resolve by inlining the config directly in the template the way this works in dev mode