Skip to content

fix(ChatMessages): prevent layout shift caused by indicator during streaming#6297

Merged
benjamincanac merged 2 commits intov4from
fix/chat-messages-indicator-layout-shift
Apr 6, 2026
Merged

fix(ChatMessages): prevent layout shift caused by indicator during streaming#6297
benjamincanac merged 2 commits intov4from
fix/chat-messages-indicator-layout-shift

Conversation

@benjamincanac
Copy link
Copy Markdown
Member

@benjamincanac benjamincanac commented Apr 5, 2026

🔗 Linked issue

Regression of 195cce8

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@github-actions github-actions Bot added the v4 #4488 label Apr 5, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 185d52b9-d8e3-40a0-8647-4ec32c9b92d8

📥 Commits

Reviewing files that changed from the base of the PR and between 25cde51 and 1c402d8.

📒 Files selected for processing (1)
  • src/runtime/components/ChatMessages.vue
✅ Files skipped from review due to trivial changes (1)
  • src/runtime/components/ChatMessages.vue

📝 Walkthrough

Walkthrough

The message rendering loop in src/runtime/components/ChatMessages.vue was changed: the single v-for on UChatMessage was replaced by a wrapping template v-for that conditionally renders each UChatMessage with v-if="message.parts?.length". Messages with no parts (or empty parts) are now omitted from rendering, so they are not registered via :ref nor projected through proxy slots. Other bound props and slot forwarding remain unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main fix: preventing layout shift caused by indicator during streaming in ChatMessages component.
Description check ✅ Passed The description references a regression and mentions the bug fix nature of the change, relating to the layout shift issue described in the title.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/chat-messages-indicator-layout-shift

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 5, 2026

npm i https://pkg.pr.new/@nuxt/ui@6297

commit: 1c402d8

@benjamincanac benjamincanac merged commit b7160e2 into v4 Apr 6, 2026
18 checks passed
@benjamincanac benjamincanac deleted the fix/chat-messages-indicator-layout-shift branch April 6, 2026 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v4 #4488

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant