[None][feat] Add Gemma3n model + Shared-kv attention support in AutoDeploy#244
Open
bmarimuthu-nv wants to merge 8 commits into
Open
[None][feat] Add Gemma3n model + Shared-kv attention support in AutoDeploy#244bmarimuthu-nv wants to merge 8 commits into
bmarimuthu-nv wants to merge 8 commits into
Conversation
Signed-off-by: Balamurugan Marimuthu <246387390+bmarimuthu-nv@users.noreply.github.com>
Signed-off-by: Balamurugan Marimuthu <246387390+bmarimuthu-nv@users.noreply.github.com>
Signed-off-by: Balamurugan Marimuthu <246387390+bmarimuthu-nv@users.noreply.github.com>
Signed-off-by: Balamurugan Marimuthu <246387390+bmarimuthu-nv@users.noreply.github.com>
Author
|
FlashInfer shared-KV backend update is pushed in What changed in this follow-up:
Why FlashInfer and not TRT-LLM:
Validation:
Generated text in the full FlashInfer run is coherent. Examples from the log:
|
Signed-off-by: Balamurugan Marimuthu <246387390+bmarimuthu-nv@users.noreply.github.com>
bmarimuthu-nv
commented
Mar 13, 2026
bmarimuthu-nv
commented
Mar 13, 2026
bmarimuthu-nv
commented
Mar 13, 2026
bmarimuthu-nv
commented
Mar 13, 2026
bmarimuthu-nv
commented
Mar 13, 2026
bmarimuthu-nv
commented
Mar 13, 2026
bmarimuthu-nv
commented
Mar 13, 2026
Signed-off-by: Balamurugan Marimuthu <246387390+bmarimuthu-nv@users.noreply.github.com>
bmarimuthu-nv
commented
Mar 13, 2026
bmarimuthu-nv
commented
Mar 13, 2026
| # limitations under the License. | ||
|
|
||
| import enum | ||
| import os |
Author
There was a problem hiding this comment.
Removed in de7ca6d. os was another stale import left behind after the earlier debug-block cleanup in sampler.py. I reran the Gemma shared-KV unit shard after this import-only cleanup: 22 passed (job_4.log).
bmarimuthu-nv
commented
Mar 13, 2026
Signed-off-by: Balamurugan Marimuthu <246387390+bmarimuthu-nv@users.noreply.github.com>
|
@bmarimuthu-nv : can we prioritize landing this PR to main? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
attn_backend: flashinferon the validatedworld_size_1pathBackend Decision
trtllmwas evaluated first, but its cached-attention kernel currently asserts when KV cache writes are disabledKV cache update cannot be disabled nowValidation
pytest -q tests/unittest/_torch/auto_deploy/unit/singlegpu/transformations/library/test_shared_kv_attention.py tests/unittest/_torch/auto_deploy/unit/singlegpu/models/test_gemma3n_modeling.py22 passed/tmp/codex-gpu-shells/7a1e5e171e/gpu/logs/job_34.loggoogle/gemma-3n-E2B-itsnapshot with:world_size_1.yamlgemma3n_shared_kv.yaml--args.attn-backend=flashinfer--args.compile-backend=torch-simpleTMPDIR=/tmpto keep executor IPC socket paths under the Unix limit/tmp/codex-gpu-shells/7a1e5e171e/gpu/logs/job_33.logE2E Output Check
The full 1-GPU FlashInfer run produced coherent outputs. Examples from the validation log:
Gravity is the force that pulls everything with mass towards each other.The capital of Iceland is Reykjavik.is_primeimplementationNotes