[None][feat] Add AD custom model for Seed-OSS family#238
Merged
Conversation
lucaslie
commented
Mar 12, 2026
lucaslie
left a comment
Author
There was a problem hiding this comment.
please rebase run all unit tests and the e2e test and post detailed, raw logs from all testing
Add prefill-only custom model implementation for ByteDance-Seed/Seed-OSS-36B-Instruct using AutoDeploy canonical ops (torch_attention, torch_rope_with_explicit_cos_sin, torch_rmsnorm). Seed-OSS is a dense Llama-style model with GQA (80 Q / 8 KV heads), SwiGLU MLP, and attention_bias=True on Q/K/V projections. Includes hierarchical equivalence tests (MLP, Attention, Decoder Layer, Full Model, Export) comparing against HF reference implementation. Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com>
…r tests The HF eager attention does NOT apply causal masking when attention_mask=None, while our custom model always uses is_causal=True. Provide explicit causal mask to HF reference to ensure equivalent comparison. Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com>
Author
|
[AGENT] Rebased onto latest Unit Tests (14/14 PASSED)E2E AutoDeploy Run (SUCCESS - full 64 layers, 4 GPUs)Command: CUDA_VISIBLE_DEVICES=0,5,6,7 python examples/auto_deploy/build_and_run_ad.py --model ByteDance-Seed/Seed-OSS-36B-Instruct --use-registryPipeline summary:
Generated outputs (all 10 prompts coherent with chain-of-thought Compile tail log: |
bmarimuthu-nv
pushed a commit
that referenced
this pull request
Mar 13, 2026
* [None][feat] Add AD custom model for Seed-OSS family Add prefill-only custom model implementation for ByteDance-Seed/Seed-OSS-36B-Instruct using AutoDeploy canonical ops (torch_attention, torch_rope_with_explicit_cos_sin, torch_rmsnorm). Seed-OSS is a dense Llama-style model with GQA (80 Q / 8 KV heads), SwiGLU MLP, and attention_bias=True on Q/K/V projections. Includes hierarchical equivalence tests (MLP, Attention, Decoder Layer, Full Model, Export) comparing against HF reference implementation. Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com> * [None][fix] Add causal mask to HF reference in attention/decoder layer tests The HF eager attention does NOT apply causal masking when attention_mask=None, while our custom model always uses is_causal=True. Provide explicit causal mask to HF reference to ensure equivalent comparison. Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com> --------- Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com>
bmarimuthu-nv
pushed a commit
that referenced
this pull request
Mar 13, 2026
* [None][feat] Add AD custom model for Seed-OSS family Add prefill-only custom model implementation for ByteDance-Seed/Seed-OSS-36B-Instruct using AutoDeploy canonical ops (torch_attention, torch_rope_with_explicit_cos_sin, torch_rmsnorm). Seed-OSS is a dense Llama-style model with GQA (80 Q / 8 KV heads), SwiGLU MLP, and attention_bias=True on Q/K/V projections. Includes hierarchical equivalence tests (MLP, Attention, Decoder Layer, Full Model, Export) comparing against HF reference implementation. Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com> * [None][fix] Add causal mask to HF reference in attention/decoder layer tests The HF eager attention does NOT apply causal masking when attention_mask=None, while our custom model always uses is_causal=True. Provide explicit causal mask to HF reference to ensure equivalent comparison. Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com> --------- Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com>
bmarimuthu-nv
pushed a commit
that referenced
this pull request
Mar 14, 2026
* [None][feat] Add AD custom model for Seed-OSS family Add prefill-only custom model implementation for ByteDance-Seed/Seed-OSS-36B-Instruct using AutoDeploy canonical ops (torch_attention, torch_rope_with_explicit_cos_sin, torch_rmsnorm). Seed-OSS is a dense Llama-style model with GQA (80 Q / 8 KV heads), SwiGLU MLP, and attention_bias=True on Q/K/V projections. Includes hierarchical equivalence tests (MLP, Attention, Decoder Layer, Full Model, Export) comparing against HF reference implementation. Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com> * [None][fix] Add causal mask to HF reference in attention/decoder layer tests The HF eager attention does NOT apply causal masking when attention_mask=None, while our custom model always uses is_causal=True. Provide explicit causal mask to HF reference to ensure equivalent comparison. Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com> --------- Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com>
bmarimuthu-nv
pushed a commit
that referenced
this pull request
Mar 18, 2026
* [None][feat] Add AD custom model for Seed-OSS family Add prefill-only custom model implementation for ByteDance-Seed/Seed-OSS-36B-Instruct using AutoDeploy canonical ops (torch_attention, torch_rope_with_explicit_cos_sin, torch_rmsnorm). Seed-OSS is a dense Llama-style model with GQA (80 Q / 8 KV heads), SwiGLU MLP, and attention_bias=True on Q/K/V projections. Includes hierarchical equivalence tests (MLP, Attention, Decoder Layer, Full Model, Export) comparing against HF reference implementation. Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com> * [None][fix] Add causal mask to HF reference in attention/decoder layer tests The HF eager attention does NOT apply causal masking when attention_mask=None, while our custom model always uses is_causal=True. Provide explicit causal mask to HF reference to ensure equivalent comparison. Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com> --------- Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com>
bmarimuthu-nv
pushed a commit
that referenced
this pull request
Mar 25, 2026
* [None][feat] Add AD custom model for Seed-OSS family Add prefill-only custom model implementation for ByteDance-Seed/Seed-OSS-36B-Instruct using AutoDeploy canonical ops (torch_attention, torch_rope_with_explicit_cos_sin, torch_rmsnorm). Seed-OSS is a dense Llama-style model with GQA (80 Q / 8 KV heads), SwiGLU MLP, and attention_bias=True on Q/K/V projections. Includes hierarchical equivalence tests (MLP, Attention, Decoder Layer, Full Model, Export) comparing against HF reference implementation. Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com> * [None][fix] Add causal mask to HF reference in attention/decoder layer tests The HF eager attention does NOT apply causal masking when attention_mask=None, while our custom model always uses is_causal=True. Provide explicit causal mask to HF reference to ensure equivalent comparison. Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com> --------- Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com>
bmarimuthu-nv
pushed a commit
that referenced
this pull request
Apr 1, 2026
* [None][feat] Add AD custom model for Seed-OSS family Add prefill-only custom model implementation for ByteDance-Seed/Seed-OSS-36B-Instruct using AutoDeploy canonical ops (torch_attention, torch_rope_with_explicit_cos_sin, torch_rmsnorm). Seed-OSS is a dense Llama-style model with GQA (80 Q / 8 KV heads), SwiGLU MLP, and attention_bias=True on Q/K/V projections. Includes hierarchical equivalence tests (MLP, Attention, Decoder Layer, Full Model, Export) comparing against HF reference implementation. Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com> * [None][fix] Add causal mask to HF reference in attention/decoder layer tests The HF eager attention does NOT apply causal masking when attention_mask=None, while our custom model always uses is_causal=True. Provide explicit causal mask to HF reference to ensure equivalent comparison. Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com> --------- Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ByteDance-Seed/Seed-OSS-36B-Instructusing AutoDeploy canonical ops (torch_attention,torch_rope_with_explicit_cos_sin,torch_rmsnorm)attention_bias=Trueon Q/K/V projections, andattention_out_bias=Falseworld_size_4.yaml)AutoDeploy End-to-End Results
Reduced layers (2 layers): Success (garbled output expected)
Full model (64 layers): Success with coherent generation across all 10 prompts
Reproduce with:
Unit Tests
Run the hierarchical equivalence tests:
Test plan
pytest tests/unittest/auto_deploy/singlegpu/models/test_seed_oss_modeling.py -vpython examples/auto_deploy/build_and_run_ad.py --model ByteDance-Seed/Seed-OSS-36B-Instruct --use-registry🤖 Generated with Claude Code